Position keyword now adds position variables in PICMI ParticleDiagnostic #4721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n01r
commented
Feb 22, 2024
Python/pywarpx/picmi.py
Outdated
| @@ -2457,7 +2458,7 @@ def diagnostic_initialize_inputs(self): | |||
| variables.add('Bx') | |||
| variables.add('By') | |||
| variables.add('Bz') | |||
| elif dataname in ['ux', 'uy', 'uz', 'Ex', 'Ey', 'Ez', 'Bx', 'By', 'Bz']: | |||
| elif dataname in ['x', 'y', 'z', 'ux', 'uy', 'uz', 'Ex', 'Ey', 'Ez', 'Bx', 'By', 'Bz', 'Er', 'Et', 'Br', 'Bt']: | |||
There was a problem hiding this comment.
What about the current variables j, though?
I don't quite see why they are missing.
There was a problem hiding this comment.
We do not anymore have an E or B field on the particle itself.
(For j we never had it.)
Prior to recently, the `'position'` string in the input of the PICMI `ParticleDiagnostic` did not add the positions because they were written out automatically. That has been changed and so we are adding them to the list of variables now. Also added the class `LabFrameParticleDiagnostic` to the docs.
- in picmi.py, the dimensions were not checked and so it would try to add variables that do not exist for a species in a lower dimension - in examples, some coordinates were named wrongly for lower dimensions than 2 but it did not matter before since positions were added automatically
n01r
force-pushed
the
topic-positionKeywordInParticleDiagsActuallyAddsPositionVariables
branch
from
9e16831 to
43949fb
Compare
|
Opening and closing because CI test for HIP failed with a timeout while installing dependencies |
ax3l
approved these changes
Feb 27, 2024
n01r
deleted the
topic-positionKeywordInParticleDiagsActuallyAddsPositionVariables
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As our documentation states, adding the string
'position'to thedata_listparameter of PICMI'sParticleDiagnosticshould add position variables. This was true by default until recently but now positions can actually be left out and are not written automatically, anymore.This PR also symmetrizes the list of accepted variables between the
LabFrameParticleDiagnosticand theParticleDiagnosticclasses while adding the former to the documentation.