Exchange guard cells with the electrostatic solver #4713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RemiLehe
changed the title
RemiLehe
force-pushed
the
exchange_guard_es
branch
from
8ac9aea to
e9bd679
Compare
RemiLehe
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RemiLehe
commented
Feb 22, 2024
RemiLehe
commented
Feb 23, 2024
lucafedeli88
requested changes
Feb 24, 2024
Examples/Tests/energy_conserving_thermal_plasma/inputs_2d_electrostatic
Outdated
Show resolved
Hide resolved
Examples/Tests/energy_conserving_thermal_plasma/inputs_2d_electrostatic
Outdated
Show resolved
Hide resolved
Comment on lines
43
to
47
| ################################# | ||
| ############ NUMERICS ########### | ||
| ################################# | ||
| warpx.serialize_initial_conditions = 1 | ||
| warpx.verbose = 1 |
There was a problem hiding this comment.
I think that these parameters could be considered "general parameters" rather then "numerics" (they are not technical parameters of the solvers used in WarpX)
Comment on lines
+9
to
+12
| warpx.do_electrostatic = labframe | ||
| algo.field_gathering = energy-conserving | ||
| algo.particle_shape = 2 | ||
| warpx.use_filter = 0 |
There was a problem hiding this comment.
I think that these parameters should be under "numerics"
Comment on lines
+29
to
+31
| geometry.dims = 2 | ||
| geometry.prob_lo = 0.0 0.0 | ||
| geometry.prob_hi = 10.*de0 10.*de0 |
There was a problem hiding this comment.
These parameters could be placed in the "general parameters" section above.
ax3l
added
bug
Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that we forgot to exchange guard cells after the Poisson solver, in the case of the electrostatic solver.
This was detected by looking at energy conservation in a periodic box with a thermal plasma:
input_2d.txt
I added a smaller version of the above test as an automated test. The test checks that the energy is within the dashed back line:
Many thanks to @oshapoval and @jlvay for helping in debugging this.