Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Particle Id Overflows #4708

Merged
merged 6 commits into from
Feb 21, 2024
Merged

Fix Particle Id Overflows #4708

merged 6 commits into from
Feb 21, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 20, 2024 •
edited
Loading

Weekly update to latest AMReX.
Weekly update to latest pyAMReX.
Weekly update to latest PICSAR (no changes).

./Tools/Release/updateAMReX.py
./Tools/Release/updatepyAMReX.py
./Tools/Release/updatePICSAR.py

@ax3l ax3l added the component: third party Changes in WarpX that reflect a change in a third-party library label Feb 20, 2024
@ax3l ax3l requested a review from WeiqunZhang February 20, 2024 16:53
@ax3l
Copy link
Member Author

ax3l commented Feb 20, 2024

Huh, the 2D rebuild from scratch now exceeds 3 hrs...

@ax3l ax3l requested a review from atmyers February 20, 2024 23:05
@ax3l ax3l enabled auto-merge (squash) February 20, 2024 23:35
@ax3l ax3l force-pushed the topic-amrexWeekly branch 2 times, most recently from 18534eb to ecac157 Compare February 21, 2024 01:32
@ax3l ax3l added the bug Something isn't working label Feb 21, 2024
lucafedeli88
lucafedeli88 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@lucafedeli88 lucafedeli88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR!

@ax3l ax3l force-pushed the topic-amrexWeekly branch from ecac157 to bea3435 Compare February 21, 2024 02:55
@ax3l ax3l requested a review from RemiLehe February 21, 2024 02:58
@ax3l
Fix ParticleContainer: amrex::Long pid
d79fbc3 
```
error: narrowing conversion from 'amrex::Long' (aka 'long') to signed type 'int' is implementation-defined [bugprone-narrowing-conversions,-warnings-as-errors]
```
@ax3l ax3l force-pushed the topic-amrexWeekly branch from bea3435 to d79fbc3 Compare February 21, 2024 06:08
@ax3l ax3l changed the title AMReX/pyAMReX/PICSAR: Weekly Update AMReX/pyAMReX/PICSAR: Weekly Update & Id Overflows Feb 21, 2024
@ax3l ax3l changed the title AMReX/pyAMReX/PICSAR: Weekly Update & Id Overflows Fix Particle Id Overflows Feb 21, 2024
@ax3l ax3l disabled auto-merge February 21, 2024 06:37
@ax3l ax3l enabled auto-merge (squash) February 21, 2024 06:37
@ax3l ax3l merged commit 8bb8ed9 into BLAST-WarpX:development Feb 21, 2024
41 checks passed
@ax3l ax3l deleted the topic-amrexWeekly branch February 21, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atmyers atmyers atmyers approved these changes

@lucafedeli88 lucafedeli88 lucafedeli88 approved these changes

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

Assignees
No one assigned
Labels
bug Something isn't working component: third party Changes in WarpX that reflect a change in a third-party library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ax3l @atmyers @lucafedeli88