[WIP] re-organizing metadata for incomplete BTD flush to close cleanly without nans #4704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RevathiJambunathan
added
bug
|
Discussed at development meeting : |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| (currentncells + ncellsflushed) * | ||
| dz_lab(warpx.getdt(lev), ref_ratio[m_moving_window_dir]); | ||
| amrex::Print() << " old z lo : " << m_snapshot_domain_lab[i_buffer].lo(m_moving_window_dir) << " \n"; | ||
| // m_snapshot_domain_lab[i_buffer].setLo(m_moving_window_dir, new_zlo); |
Check notice
Code scanning / CodeQL
Commented-out code Note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example in
Examples/Physics_applications/laser_acceleration/inputs_2d_boostwill produce nans in openpmd output if BTD flush is incomplete (i.e., run with fewer timesteps)
In this PR, this is fixed by changing the meta data for the snapshot box and geometry, so its consistent with all the previous buffers that were flushed and the number of cells in the current flush.
Now the same example, when run with fewer timesteps (i.e., scenario where we have an incomplete BTD flush), has consistent meta data and therefore will not show nans for the missing cell data in the OpenPMD output.
This PR fixes the meta-data for the fields
To do :
It wont change the way we do offsets, except for the last incomplete flush, wher the offset will be zero, because the index of the geometry is updated to be consistent with the incomplete buffer.