Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: NVHPC 24.1 #4679

Merged
merged 3 commits into from
Feb 8, 2024
Merged

CI: NVHPC 24.1 #4679

merged 3 commits into from
Feb 8, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Feb 8, 2024

Update NVHPC from 21.11 to 24.1.

Needed for int128 from AMReX-Codes/amrex#3742 in #4678

Update NVHPC from 21.11 to 24.1.
@ax3l ax3l added backend: cuda Specific to CUDA execution (GPUs) component: tests Tests and CI labels Feb 8, 2024
@ax3l ax3l requested a review from WeiqunZhang February 8, 2024 03:46
@ax3l
Copy link
Member Author

ax3l commented Feb 8, 2024

"/home/runner/work/WarpX/WarpX/build/_deps/fetchedpybind11-src/include/pybind11/pybind11.h", line 102: error: expected a ")"
  initialize(std::forward< Func> (f), (detail::function_signature_t< Func>  *)nullptr, extra...); 
                                                                                                ^

Reported as Nvidia bug no. 4491413
The issue seems to be part of HPC SDK since 23.9.

Reenable once compiler bug is fixed.
@ax3l ax3l enabled auto-merge (squash) February 8, 2024 05:45
@ax3l
Copy link
Member Author

ax3l commented Feb 8, 2024

Uff, final NVHPC link:

/usr/bin/ld: lib/libwarpx.3d.MPI.CUDA.DP.PDP.OPMD.PSATD.EB.QED.a(BTD_Plotfile_Header_Impl.cpp.o): in function `BTDPlotfileHeaderImpl::BTDPlotfileHeaderImpl(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
/home/runner/work/WarpX/WarpX/Source/Diagnostics/BTD_Plotfile_Header_Impl.cpp:26: undefined reference to `amrex::Vector<std::array<double, 3ul>, std::allocator<std::array<double, 3ul> > >::~Vector()'

@ax3l
Copy link
Member Author

ax3l commented Feb 8, 2024

Looks like an issue with the members

    /** Lower corner physical coordinates of each fab in the plotfile. */
    amrex::Vector<amrex::Array<amrex::Real, AMREX_SPACEDIM> > m_glo {{AMREX_D_DECL(0.,0.,0.)}};
    /** Upper corner physical coordinates of each fab in the plotfile. */
    amrex::Vector<amrex::Array<amrex::Real, AMREX_SPACEDIM> > m_ghi {{AMREX_D_DECL(1.,1.,1.)}};

Try to address NVHPC 24.1 linker issue:
```
/usr/bin/ld: lib/libwarpx.3d.MPI.CUDA.DP.PDP.OPMD.PSATD.EB.QED.a(BTD_Plotfile_Header_Impl.cpp.o): in function `BTDPlotfileHeaderImpl::BTDPlotfileHeaderImpl(std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&)':
/home/runner/work/WarpX/WarpX/Source/Diagnostics/BTD_Plotfile_Header_Impl.cpp:26: undefined reference to `amrex::Vector<std::array<double, 3ul>, std::allocator<std::array<double, 3ul> > >::~Vector()'
```
@ax3l ax3l merged commit c6875f4 into BLAST-WarpX:development Feb 8, 2024
41 checks passed
@ax3l ax3l deleted the ci-nvhpc-24.1 branch February 8, 2024 15:56
@ax3l
Copy link
Member Author

ax3l commented Feb 8, 2024

Ok, that last push fixed it: Move m_glo/m_ghi init to .cpp

@ax3l
Copy link
Member Author

ax3l commented Oct 12, 2024

For the above NVCC + NVHPC (host-side) issue, I got a notification this week that this might be fixed in the next release of CUDA SDK and/or the NVIDIA HPC SDK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: cuda Specific to CUDA execution (GPUs) component: tests Tests and CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants