Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: update instructions for Fugaku supercomputer (Riken, Japan) #4656

Merged
merged 18 commits into from
Feb 20, 2024

Conversation

lucafedeli88
Copy link
Member

@lucafedeli88 lucafedeli88 commented Jan 31, 2024

This PR updates the scripts and the instructions to compile WarpX for the Fugaku supercomputer.
The PR introduces also a small change to BinaryCollision.H . The reason is that the Fujitsu compiler in clang mode is based on an old version of clang and sees this code as an error (see here, code snippet copied from here ):

struct T {
    T() noexcept(false) { }
    ~T() noexcept(false) { }
};

struct A
{
    A() noexcept = default;
    ~A() noexcept = default;
    T t;
};

while more modern compilers silently delete the noexcept methods.

I've also removed polly from the compilation flags since otherwise I observe a crash of the Fujitsu compiler. Removing polyhedral optimizations does not seem to affect performances.

@lucafedeli88 lucafedeli88 added component: documentation Docs, readme and manual machine / system Machine or system-specific issue labels Jan 31, 2024
@ax3l ax3l self-requested a review February 1, 2024 18:08
@lucafedeli88 lucafedeli88 changed the title [WIP] Docs: update instructions for Fugaku supercomputer (Riken, Japan) Docs: update instructions for Fugaku supercomputer (Riken, Japan) Feb 5, 2024
@ax3l ax3l self-assigned this Feb 8, 2024
Copy link
Member

@ax3l ax3l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! ✨

@ax3l ax3l merged commit 5a7c325 into BLAST-WarpX:development Feb 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: documentation Docs, readme and manual machine / system Machine or system-specific issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants