AMReX: Latest development
#4654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
added
the
component: third party
This was referenced Jan 31, 2024
|
Let's try again with AMReX-Codes/amrex#3738 Update: updated. |
WeiqunZhang
pushed a commit
to AMReX-Codes/amrex
that referenced
this pull request
Jan 31, 2024
## Summary Move into type to mitigate MSVC compile errors: ``` Src\Particle\AMReX_ParticleTile.H(48,5): error C2219: syntax error: type qualifier must be after '*' ``` ## Additional background Follow-up to #3736. Seen in BLAST-WarpX/warpx#4654 ## Checklist The proposed changes: - [x] fix a bug or incorrect behavior in AMReX - [ ] add new capabilities to AMReX - [ ] changes answers in the test suite to more than roundoff level - [ ] are likely to significantly affect the results of downstream AMReX users - [ ] include documentation in the code and/or rst files, if appropriate
ax3l
force-pushed
the
topic-amrexWeekly
branch
from
15dd7d9 to
4ce6814
Compare
WeiqunZhang
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest AMReX
developmentfor pure SoA particle layout fixes from Tuesday for #4653../Tools/Release/updateAMReX.py