Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Fast, Local Compilation #4603

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Doc: Fast, Local Compilation #4603

merged 6 commits into from
Jan 23, 2024

Conversation

ax3l
Copy link
Member

@ax3l ax3l commented Jan 10, 2024

Workflows for compiling without or with slow internet access or when working on WarpX and its dependencies at the same time.

@ax3l
Doc: Fast, Local Compilation
a90ccc3 
Workflows for compiling without or with slow internet access or
when working on WarpX and its dependencies at the same time.
@ax3l ax3l added the component: documentation Docs, readme and manual label Jan 10, 2024
@ax3l ax3l requested a review from dpgrote January 10, 2024 20:48
lucafedeli88
lucafedeli88 reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@lucafedeli88 lucafedeli88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a couple of comments

@ax3l ax3l mentioned this pull request Jan 12, 2024
Merged
ax3l and others added 4 commits January 12, 2024 09:26
@ax3l @dpgrote
@lucafedeli88 @roelof-groenewald
Fix Typos
1879597 
Co-authored-by: David Grote <dpgrote@lbl.gov>
Co-authored-by: Luca Fedeli <luca.fedeli.88@gmail.com>
Co-authored-by: Roelof Groenewald <40245517+roelof-groenewald@users.noreply.github.com>
@ax3l
Doc: Rapid Python Dev (no LTO/IPO, no deps)
46aa1e1
@ax3l
One more link on CMAKE_PREFIX_PATH
9c71e75
@ax3l
CCache Notes
485fedf
roelof-groenewald
roelof-groenewald approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@roelof-groenewald roelof-groenewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but I'll hold off on merging since others had comments as well.

@ax3l ax3l force-pushed the doc-local-compile branch from 861578d to 0cb9c29 Compare January 17, 2024 19:37
@ax3l ax3l requested a review from dpgrote January 17, 2024 19:39
dpgrote
dpgrote approved these changes Jan 17, 2024
View reviewed changes
Copy link
Member

@dpgrote dpgrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ax3l ax3l merged commit 94babda into BLAST-WarpX:development Jan 23, 2024
@ax3l ax3l deleted the doc-local-compile branch January 23, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpgrote dpgrote dpgrote approved these changes

@lucafedeli88 lucafedeli88 lucafedeli88 approved these changes

@roelof-groenewald roelof-groenewald roelof-groenewald approved these changes

@RemiLehe RemiLehe Awaiting requested review from RemiLehe

@WeiqunZhang WeiqunZhang Awaiting requested review from WeiqunZhang

Assignees

@RemiLehe RemiLehe

Labels
component: documentation Docs, readme and manual
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ax3l @dpgrote @lucafedeli88 @roelof-groenewald @RemiLehe