-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Documentation for Laser-Ion Acceleration from Planar Target #4569
Improve Documentation for Laser-Ion Acceleration from Planar Target #4569
Conversation
9cf8890
to
55b64a2
Compare
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
8286724
to
f336dfc
Compare
Examples/Physics_applications/laser_ion/visualize_densities_and_fields_2d.py
Fixed
Show fixed
Hide fixed
99abad2
to
3bd02bf
Compare
30e71d6
to
3a1d391
Compare
55fce79
to
a461768
Compare
3d6cb25
to
ca3fa6a
Compare
Hi @eebasso, I heard from @RTSandberg that you worked some magic to make the labels work for RST's Could you tell me what in particular you fixed to make this work? 🙂 |
@n01r I'm looking at that now. I'll let you know if I figure it out. |
Thank you, @eebasso! 🙏 |
.. figure:: https://user-images.githubusercontent.com/5416860/295003882-c755fd47-4bb3-4439-9319-c48214cbaafd.png | ||
:alt: Longitudinal phase space of forward-flying electrons in a 2 degree opening angle. | ||
:width: 100% | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The :alt:
parameter does not specify the caption text, and only appears if the image doesn't load. https://sublime-and-sphinx-guide.readthedocs.io/en/latest/images.html#alt-text
Therefore, you need to repeat the text without the :alt:
parameter in order to actually have a caption. Furthermore, make sure that there is an empty new line above the caption text. In this case, it should look like
.. figure:: https://user-images.githubusercontent.com/5416860/295003882-c755fd47-4bb3-4439-9319-c48214cbaafd.png
:alt: Longitudinal phase space of forward-flying electrons in a 2 degree opening angle.
:width: 100%
Longitudinal phase space of forward-flying electrons in a 2 degree opening angle.
.. _fig-tnsa-ps-protons-pinhole:
I don't know why the empty line above the caption text is needed, but that's what I found via testing. As a bonus, this also seemed to fix the "undefined label" error coming from :numref:
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @eebasso, thanks for testing this!
Initially, I did not intend for there to be a caption since the text around is also short and holds all information. 🙂
However, I added it now.
Unfortunately, that does not fix the "undefined label" warnings for me when I build the docs locally (despite the empty line above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait! But the CI-built docs now have :numref:
working! 🎉
Thanks, @eebasso!
(Now I only need to figure out why locally that does not fix it 🤔)
Hi @n01r, the CI test seems to fail. Can you run |
ecb58f6
to
a6ec5b3
Compare
Hi @ax3l, should be fixed now :) |
a6ec5b3
to
33b0336
Compare
Hmm, at least locally it passes. But online it does not seem to pass. How do I view Azure pipeline backtraces? |
33b0336
to
8355e87
Compare
8ff6b3b
to
a486f0f
Compare
- add PICMI input - add vis script - update docs - add Python regression test - update phase space analysis script - add checksum regression test
for more information, see https://pre-commit.ci
a486f0f
to
7781d68
Compare
Same problem with non-PICMI (application/executable/inputs file) run... |
The variables and data_lists exclude |
Thanks a lot, @ax3l! |
- Species selections - Filter details
Update checksums in Python_LaserIonAcc2d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, thank you so much 🚀 ✨
analysis
but could later be counted as a visualization script and renamed toplot_...
)Phase space for electrons

Phase space for ions

Particle densities

Electromagnetic fields
