Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up charge deposition code duplication #4113

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Clean up charge deposition code duplication #4113

merged 2 commits into from
Aug 2, 2023

Conversation

roelof-groenewald
Copy link
Member

@roelof-groenewald roelof-groenewald commented Jul 24, 2023 •
edited
Loading

Simple code duplication reduction.

@roelof-groenewald roelof-groenewald added the cleaning Clean code, improve readability label Jul 24, 2023
@ax3l ax3l requested a review from EZoni July 24, 2023 23:24
EZoni
EZoni approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@EZoni EZoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @roelof-groenewald! Looks good to me.

@EZoni
Copy link
Member

EZoni commented Aug 1, 2023

Can you please rebase on development and fix the conflicting file?

@EZoni EZoni enabled auto-merge (squash) August 2, 2023 00:49
@EZoni EZoni merged commit 8ec5eb6 into BLAST-WarpX:development Aug 2, 2023
@roelof-groenewald roelof-groenewald deleted the dep_rho_cleanup branch August 2, 2023 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EZoni EZoni EZoni approved these changes

Assignees

@EZoni EZoni

Labels
cleaning Clean code, improve readability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roelof-groenewald @EZoni