forked from wrye-bash/wrye-bash
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for specifying oblivionMods via CLI
This is a quick untested hack that enables setting the WB root directory (oblivionMods) through a command line argument: --bash-root (short version -R, for ... root, idk). Motivation is reducing reliance on bash.ini, allowing configuration to be set at init time or through settings dict.
- Loading branch information
Showing
3 changed files
with
8 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
93da4b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Infernio this is a rather crude hack, but should be harmless and is very convenient for testing. Let me know if there's more work to be done on this front!
93da4b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this does not default to gamedir/../game Mods if the specified root does not exist/is invalid, just erroring out instead. Also pending support for saving and properly retrieving root path from settings, so users won't need to pass --bash-root "whatever" every time they start WB
93da4b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks OK at first glance. Not sure I'll have much time for WB over the coming weeks though to review and merge it :/
@Utumno, can you take a look?
93da4b1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will have a look asap which will probably be Tuesday though - I have also paused work on the launchers settings tab but it's not forgotten - it's just some core refactoring that has precedence and I am in the process of testing - by the way one of the regressions was in setting launchers from ini lol