Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified NAA tests with MSA account #1995

Merged
merged 11 commits into from
Jan 26, 2024
Merged

Modified NAA tests with MSA account #1995

merged 11 commits into from
Jan 26, 2024

Conversation

somalaya
Copy link
Contributor

@somalaya somalaya commented Jan 8, 2024 •
edited
Loading

  1. Nested app auth tests were previously working only with AAD accounts because there was a bug on ESTS side and was being fixed. I had commented it out. Now that it is fixed, modified the tests to run with MSA account as well.
  2. The tests also needed PRTV3 to be enabled explicitly using flights in brokerHost app. Now that it is at 100%, I have removed that code as well.
  3. TestCase2690048 does not need to be run with MSA account.

@somalaya somalaya marked this pull request as ready for review January 8, 2024 17:18
@somalaya somalaya requested a review from a team as a code owner January 8, 2024 17:18
@somalaya somalaya merged commit 7ebbe76 into dev Jan 26, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shahzaibj shahzaibj shahzaibj approved these changes

@fadidurah fadidurah fadidurah approved these changes

Assignees
No one assigned
Labels
test-automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@somalaya @shahzaibj @fadidurah