Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: decrease minimum allowed size for OsDiskSizeGB from 100 to 30 #688

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

feat: decrease minimum allowed size for OsDiskSizeGB from 100 to 30 #688

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/karpenter-crd/templates/karpenter.azure.com_aksnodeclasses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ spec:
default: 128
description: osDiskSizeGB is the size of the OS disk in GB.
format: int32
minimum: 100
minimum: 30
type: integer
tags:
additionalProperties:
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/crds/karpenter.azure.com_aksnodeclasses.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ spec:
default: 128
description: osDiskSizeGB is the size of the OS disk in GB.
format: int32
minimum: 100
minimum: 30
type: integer
tags:
additionalProperties:
Expand Down
2 changes: 1 addition & 1 deletion pkg/apis/v1alpha2/aksnodeclass.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ type AKSNodeClassSpec struct {
// +optional
VNETSubnetID *string `json:"vnetSubnetID,omitempty"`
// +kubebuilder:default=128
// +kubebuilder:validation:Minimum=100
// +kubebuilder:validation:Minimum=30
// osDiskSizeGB is the size of the OS disk in GB.
OSDiskSizeGB *int32 `json:"osDiskSizeGB,omitempty"`
// ImageID is the ID of the image that instances use.
Expand Down
2 changes: 1 addition & 1 deletion pkg/controllers/nodeclass/hash/suite_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ var _ = Describe("NodeClass Hash Controller", func() {

},
Entry("ImageFamily Drift", &v1alpha2.AKSNodeClass{Spec: v1alpha2.AKSNodeClassSpec{ImageFamily: lo.ToPtr("AzureLinux")}}),
Entry("OSDiskSizeGB Drift", &v1alpha2.AKSNodeClass{Spec: v1alpha2.AKSNodeClassSpec{OSDiskSizeGB: lo.ToPtr(int32(100))}}),
Entry("OSDiskSizeGB Drift", &v1alpha2.AKSNodeClass{Spec: v1alpha2.AKSNodeClassSpec{OSDiskSizeGB: lo.ToPtr(int32(30))}}),
Entry("Tags Drift", &v1alpha2.AKSNodeClass{Spec: v1alpha2.AKSNodeClassSpec{Tags: map[string]string{"keyTag-test-3": "valueTag-test-3"}}}),
)
It("should update AKSNodeClass-hash-version annotation when the AKSNodeClass-hash-version on the NodeClass does not match with the controller hash version", func() {
Expand Down
Loading