-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: garbage collection controller removes orphaned nics #686
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks pretty good. Good to get the test coverage.
Main points looking to have addressed are test timeout, and comments clarifying magic indexes.
fix: propagating values to makefile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Have not finished the review, capturing feedback so far - probably already actionable. Overall like where this is going!)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very close
Running e2e suite with changes to imports: https://github.com/Azure/karpenter-provider-azure/actions/runs/13386002889, lets see if it works as expected. |
Description
This pr adds an e2e test that can be ran locally for network interface garbage collection.
How was this change tested?
Does this change impact docs?
Release Note