Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: garbage collection controller removes orphaned nics #686

Merged
merged 31 commits into from
Feb 21, 2025

Conversation

Bryce-Soghigian
Copy link
Collaborator

@Bryce-Soghigian Bryce-Soghigian commented Feb 9, 2025

Description
This pr adds an e2e test that can be ran locally for network interface garbage collection.

How was this change tested?

  • make az-e2etests on byo vnet + managed vnet
  • E2E Run

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note


@Bryce-Soghigian Bryce-Soghigian marked this pull request as ready for review February 9, 2025 05:07
Copy link
Collaborator

@charliedmcb charliedmcb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks pretty good. Good to get the test coverage.

Main points looking to have addressed are test timeout, and comments clarifying magic indexes.

@Bryce-Soghigian
Copy link
Collaborator Author

Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Have not finished the review, capturing feedback so far - probably already actionable. Overall like where this is going!)

Copy link
Collaborator

@tallaxes tallaxes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very close

@Bryce-Soghigian
Copy link
Collaborator Author

Running e2e suite with changes to imports: https://github.com/Azure/karpenter-provider-azure/actions/runs/13386002889, lets see if it works as expected.

@tallaxes tallaxes merged commit 11f23ea into main Feb 21, 2025
12 checks passed
@tallaxes tallaxes deleted the bsoghigian/e2e/nic-gc branch February 21, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants