feat: validation enforcing vnet guid is set for overlay cni clusters #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d google uuid lib based on this benchmark test https://gist.github.com/mattes/69a4ab7027b9e8ee952b5843e7ca6955
…gers vnet guid validation, this modifies that test to pass in an empty string
matthchr
reviewed
Feb 7, 2025
matthchr
previously approved these changes
Feb 20, 2025
tallaxes
previously approved these changes
Feb 21, 2025
tallaxes
added
area/networking
tallaxes
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After we roll out the v0.7.2 release, we can remove the fallback to the vnet client. This pr also introduces stricter validation to vnet guid to make it clear its required.
How was this change tested?
Does this change impact docs?
Release Note