Upgrade version of MySQL to 2023-12-30 #4549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theunrepentantgeek
requested review from
davefellows,
matthchr,
babbageclunk and
super-harsh
as code owners
theunrepentantgeek
changed the title
matthchr
approved these changes
Jan 31, 2025
| ) | ||
|
|
||
| func Test_DBForMySQL_FlexibleServer_20231230_CRUD(t *testing.T) { | ||
| t.Parallel() |
There was a problem hiding this comment.
If we're pretty sure that this is correct but can't possibly record tests for it for some reason, we can always mark this t.Skip() and file an item to come back to it once we get to the root cause of why they're rejecting us...
Not ideal though.
There was a problem hiding this comment.
We got quota and I was able to record the tests.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 17, 2025
* Update azure-arm.yaml * Update generated files * Implement conversion override for SourceServerResourceId * Add samples * Add test for new version * Update version released * Add recordings * Remove custom region from test
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Test failed in merge queue due to: Though now that I look, I actually missed fixing this fully... I will send another PR |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates the supported version of
dbformysqlto v2023-12-30.Closes #3839
How does this PR make you feel?
Checklist