-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RDBMS] az postgres flexible-server fabric-mirroring
: BUG FIX, Space separate list of databases was only picking up first name
#31000
Conversation
️✔️AzureCLI-FullTest
|
❌AzureCLI-BreakingChangeTest
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@evelyn-ys can checks please be triggered |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Related command
az postgres flexible-server fabric-mirroring start
az postgres flexible-server fabric-mirroring update-databases
Description
Bug in update-databases command where using space separated list of databases. It does not work as expected. It takes into account only the first one and ignores the rest.
Remove unnecessary call to restart server
Testing Guide
az postgres flexible-server fabric-mirroring update-databases --database-names testdb2 testdb3 -g testrg -s test-fabric
{
"allowedValues": ".*",
"dataType": "String",
"defaultValue": "",
"description": "Sepcifies the list of databases for which to enable mirroring.",
"documentationLink": null,
"id": "/subscriptions/subid/resourceGroups/testrg/providers/Microsoft.DBforPostgreSQL/flexibleServers/test-fabric/configurations/azure.mirror_databases",
"isConfigPendingRestart": false,
"isDynamicConfig": true,
"isReadOnly": false,
"name": "azure.mirror_databases",
"resourceGroup": " testrg",
"source": "user-override",
"systemData": null,
"type": "Microsoft.DBforPostgreSQL/flexibleServers/configurations",
"unit": null,
"value": "testdb2,testdb3"
}
History Notes
[RDBMS]
az postgres flexible-server fabric-mirroring
: Fix for space separated list of databases duringstart
andupdate-databases
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.