{ACR} Fixed a bug where creating cache rule without credential set would fail #30984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With latest az cli 2.70 release we unfortunately introduced a regression. Creating a cache rule without a credential set would crash. It is caused by a local variable not declared in the correct scope. A bug issue has been created to track this issue: Azure/acr#822 This commit fixed the issue. Now creating cache rules work as expected.
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
wangzelin007 and
yonzhan
microsoft-github-policy-service
bot
added
Auto-Assign
|
ACR |
zhoxing-ms
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az acr cache createDescription
With latest az cli 2.70 release we unfortunately introduced a regression. Creating a cache rule without a credential set would crash. It is caused by a local variable not declared in the correct scope.
A bug issue has been created to track this issue:
Azure/acr#822
This commit fixed the issue. Now creating cache rules work as expected.
Testing Guide
First create a container registry, e.g.
Then create a cache rule without credential set, e.g.
The creation should succeed without any error.
Then test the scenario of 'creating a cache rule with credential set', to insure no regression has been introduced.
Create a credential set, e.g.
Create a cache rule with credential set, e.g.