{DisconnectedOperations} Added az edge disconnected-operation edge-marketplace offer command
#30980
Conversation
kotewar
requested review from
kairu-ms,
zhoxing-ms,
calvinhzy,
necusjz and
bebound
as code owners
|
Validation for Azure CLI Full Test Starting...
Thanks for your contribution! |
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
DisconnectedOperations |
|
@microsoft-github-policy-service agree company="Microsoft" |
|
|
||
| # Register the parent command group | ||
| with self.command_group( | ||
| "disconnectedoperations", |
There was a problem hiding this comment.
Please use edge disconnected-operation as the top level command group
There was a problem hiding this comment.
Would it be okay if edge keyword repeats? the command would look something like
az edge disconnected-operation edge-marketplace offer list
|
|
||
| # Register the subgroup and its commands | ||
| with self.command_group( | ||
| "disconnectedoperations edgemarketplace", |
There was a problem hiding this comment.
please separate the edgemarketplace by -
| g.custom_command( | ||
| "listoffers", "list_offers", table_transformer=transform_offers_table | ||
| ) | ||
| g.custom_command( | ||
| "getoffer", "get_offer", table_transformer=transform_offer_table | ||
| ) | ||
| g.custom_command("packageoffer", "package_offer") |
There was a problem hiding this comment.
the command should be renamed as offer list offer show and offer package based on cli command name guideline
| logger = get_logger(__name__) | ||
| management_endpoint = _get_management_endpoint(cmd.cli_ctx) | ||
| subscription_id = get_subscription_id(cmd.cli_ctx) | ||
|
|
||
| # Construct URL with parameters | ||
| url = ( | ||
| f"https://{management_endpoint}" | ||
| f"/subscriptions/{subscription_id}" | ||
| f"/resourceGroups/{resource_group_name}" | ||
| f"/providers/{provider_namespace}/dataBoxEdgeDevices/{resource_name}" | ||
| f"/providers/{sub_provider}/offers/{publisher_name}:{offer_name}" | ||
| f"?api-version={api_version}" | ||
| ) |
There was a problem hiding this comment.
For the arm request, please use the aaz-dev-tools to generate atomic command, then you can use it directly in your custom functions. Like this
|
BTW, this module should be delivered as an extension. |
|
|
||
| from azure.cli.command_modules.disconnectedoperations._client_factory import cf_image | ||
| from azure.cli.core import AzCommandsLoader | ||
|
|
There was a problem hiding this comment.
Please input the _help.py here like this
@kairu-ms We actually need this module in a disconnected environment, so internet won't be there to install any extension on top of the CLI. |
kotewar
changed the title
az disconnectedoperations edgemarketplace packageoffer commandaz disconnectedoperations edge-marketplace offer command
kotewar
changed the title
az disconnectedoperations edge-marketplace offer commandaz edge disconnected-operation edge-marketplace offer command
Related command
az edge disconnected-operation(new)Description
This PR adds support for packaging Microsoft.edgemarketplace images.
Corresponding AAZ PR: Azure/aaz#710
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.