{Compute} az disk-encryption-set: Migrate to AAZ
#30894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| disk-encryption-set create | cmd disk-encryption-set create update parameter disk_encryption_set_name: added property aaz_type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter disk_encryption_set_name: added property type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter disk_encryption_set_name: removed property id_part=name |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter disk_encryption_set_name: updated property options from ['--name', '-n'] to ['--disk-encryption-set-name', '--name', '-n'] |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter enable_auto_key_rotation: added property aaz_type=bool |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter enable_auto_key_rotation: added property type=bool |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter enable_auto_key_rotation: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter encryption_type: added property aaz_type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter encryption_type: added property type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter encryption_type: updated property choices from ['ConfidentialVmEncryptedWithCustomerKey', 'EncryptionAtRestWithCustomerKey', 'EncryptionAtRestWithPlatformAndCustomerKeys', 'EncryptionAtRestWithPlatformKey'] to ['ConfidentialVmEncryptedWithCustomerKey', 'EncryptionAtRestWithCustomerKey', 'EncryptionAtRestWithPlatformAndCustomerKeys'] |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter federated_client_id: added property aaz_type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter federated_client_id: added property type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter key_url: added property aaz_type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter key_url: added property type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter location: added property aaz_type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter location: updated property type from custom_type to string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter mi_system_assigned: added property aaz_type=bool |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter mi_system_assigned: added property type=bool |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter mi_system_assigned: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter mi_user_assigned: added property aaz_type=AAZListArg |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter mi_user_assigned: added property type=List<String> |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter no_wait: added property aaz_type=bool |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter no_wait: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter no_wait: added property nargs=? |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter no_wait: added property type=bool |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter resource_group_name: added property aaz_type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter resource_group_name: added property type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter source_vault: added property aaz_type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter source_vault: added property type=string |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter tags: added property aaz_type=AAZDictArg |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter tags: added property type=Dict<String,String> |
||
| disk-encryption-set create | cmd disk-encryption-set create update parameter tags: updated property nargs from * to + |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter disk_encryption_set_name: added property aaz_type=string |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter disk_encryption_set_name: added property type=string |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter disk_encryption_set_name: updated property options from ['--name', '-n'] to ['--disk-encryption-set-name', '--name', '-n'] |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter mi_system_assigned: added property aaz_type=bool |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter mi_system_assigned: added property type=bool |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter mi_system_assigned: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter mi_system_assigned: updated property name from mi_system_assigned to system_assigned |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter mi_user_assigned: added property aaz_type=AAZListArg |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter mi_user_assigned: added property type=List<String> |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter mi_user_assigned: updated property name from mi_user_assigned to user_assigned |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter resource_group_name: added property aaz_type=string |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter resource_group_name: added property type=string |
||
| disk-encryption-set identity assign | cmd disk-encryption-set identity assign update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove removed property confirmation |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter disk_encryption_set_name: added property aaz_type=string |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter disk_encryption_set_name: added property type=string |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter disk_encryption_set_name: updated property options from ['--name', '-n'] to ['--disk-encryption-set-name', '--name', '-n'] |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter mi_system_assigned: added property aaz_type=bool |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter mi_system_assigned: added property type=bool |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter mi_system_assigned: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter mi_system_assigned: updated property name from mi_system_assigned to system_assigned |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter mi_user_assigned: added property aaz_type=AAZListArg |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter mi_user_assigned: added property type=List<String> |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter mi_user_assigned: updated property name from mi_user_assigned to user_assigned |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter resource_group_name: added property aaz_type=string |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter resource_group_name: added property type=string |
||
| disk-encryption-set identity remove | cmd disk-encryption-set identity remove update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk-encryption-set update | cmd disk-encryption-set update added parameter no_wait |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter disk_encryption_set_name: added property aaz_type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter disk_encryption_set_name: added property type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter disk_encryption_set_name: updated property options from ['--name', '-n'] to ['--disk-encryption-set-name', '--name', '-n'] |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter enable_auto_key_rotation: added property aaz_type=bool |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter enable_auto_key_rotation: added property type=bool |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter enable_auto_key_rotation: updated property choices from ['false', 'true'] to ['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes'] |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter federated_client_id: added property aaz_type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter federated_client_id: added property type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter key_url: added property aaz_type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter key_url: added property type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter resource_group_name: added property aaz_type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter resource_group_name: added property type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter resource_group_name: updated property name from resource_group_name to resource_group |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter source_vault: added property aaz_type=string |
||
| disk-encryption-set update | cmd disk-encryption-set update update parameter source_vault: added property type=string |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
yonzhan,
zhoxing-ms and
yanzhudd
microsoft-github-policy-service
bot
added
the
Compute
cxznmhdcxz
force-pushed
the
disk-encryption-set-migrate
branch
from
946fc18 to
021d945
Compare
yanzhudd
reviewed
Feb 27, 2025
yanzhudd
reviewed
Feb 27, 2025
yanzhudd
reviewed
Mar 3, 2025
yanzhudd
reviewed
Mar 3, 2025
yanzhudd
reviewed
Mar 3, 2025
yanzhudd
reviewed
Mar 3, 2025
yanzhudd
reviewed
Mar 3, 2025
yanzhudd
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az disk-encryption-set create/delete/list/show/updateaz disk-encryption-set identity assign/remove/showDescription
Migrate to AAZ based
Azure/aaz#701
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.