-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Connector] az webapp connection create fabric-sql
: Fix interactive mode & allow new parameters --fabric-workspace-uuid
and fabric-sql-db-uuid
#30881
Conversation
️✔️AzureCLI-FullTest
|
Hi @Tonychen0227, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp connection create fabric-sql | cmd containerapp connection create fabric-sql added parameter fabric_sql_db_uuid |
||
containerapp connection create fabric-sql | cmd containerapp connection create fabric-sql added parameter fabric_workspace_uuid |
||
functionapp connection create fabric-sql | cmd functionapp connection create fabric-sql added parameter fabric_sql_db_uuid |
||
functionapp connection create fabric-sql | cmd functionapp connection create fabric-sql added parameter fabric_workspace_uuid |
||
webapp connection create fabric-sql | cmd webapp connection create fabric-sql added parameter fabric_sql_db_uuid |
||
webapp connection create fabric-sql | cmd webapp connection create fabric-sql added parameter fabric_workspace_uuid |
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
src/azure-cli/azure/cli/command_modules/serviceconnector/_validators.py
Outdated
Show resolved
Hide resolved
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
az webapp connection create fabric-sql
- Fix interactive mode & allow new parameters --fabric-workspace-uuid
and fabric-sql-db-uuid
az webapp connection create fabric-sql
- Fix interactive mode & allow new parameters --fabric-workspace-uuid
and fabric-sql-db-uuid
az webapp connection create fabric-sql
: Fix interactive mode & allow new parameters --fabric-workspace-uuid
and fabric-sql-db-uuid
All checks passed - @kairu-ms could you please merge when possible? Thanks! |
@yanzhudd @ReaNAiveD - ping for merge in time for https://github.com/Azure/azure-cli/milestone/152, if possible - azp run is healthy and approvals met |
…eractive mode & allow new parameters `--fabric-workspace-uuid` and `fabric-sql-db-uuid` (Azure#30881) * Full solution with test success * Small fix * Remove unnecessary custom changes * Recording * Fix comment out unit test * Add app config id fix * add back custom.py changes * Review comments * style style --------- Co-authored-by: Tony Chen (DevDiv) <chentony@microsoft.com>
Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a
: Make some customer-facing breaking change[Component Name 2]
az command b
: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.