Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Storage] az storage account, az storage share-rm: Support Azure Files provisioned v2 skus, add az storage account file-service-usage #30873

Merged
merged 8 commits into from
Feb 25, 2025

Conversation

calvinhzy
Copy link
Member

@calvinhzy calvinhzy commented Feb 24, 2025

Related command

Description

Migrate az storage share-rm create/update/show/list/delete to codegen to bypass server side datetime response deserialization issue when using python sdk.
Azure/aaz#697
Add support for provisioned v2 features.

Testing Guide

History Notes

[Storage] az storage account create: Add new --sku StandardV2_LRS/StandardV2_ZRS/StandardV2_ZRS/StandardV2_ZRS/PremiumV2_LRS/PremiumV2_ZRS for provisioned v2 support
[Storage] az storage account file-service-usage: Support getting file-service usage for storage account
[Storage] az storage share-rm create/update: Add --paid-bursting-enabled, --paid-bursting-max-bandwidth-mibps, --paid-bursting-max-iops for provisioned v1, add --provisioned-bandwidth-mibps, --provisioned-iops for provisioned v2 accounts


This checklist is used to make sure that common guidelines for a pull request are followed.

Copy link

azure-client-tools-bot-prd bot commented Feb 24, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.9
️✔️ams
️✔️latest
️✔️3.12
️✔️3.9
️✔️apim
️✔️latest
️✔️3.12
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️aro
️✔️latest
️✔️3.12
️✔️3.9
️✔️backup
️✔️latest
️✔️3.12
️✔️3.9
️✔️batch
️✔️latest
️✔️3.12
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.9
️✔️billing
️✔️latest
️✔️3.12
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.9
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.9
️✔️config
️✔️latest
️✔️3.12
️✔️3.9
️✔️configure
️✔️latest
️✔️3.12
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.9
️✔️container
️✔️latest
️✔️3.12
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️dls
️✔️latest
️✔️3.12
️✔️3.9
️✔️dms
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.9
️✔️find
️✔️latest
️✔️3.12
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.9
️✔️identity
️✔️latest
️✔️3.12
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️lab
️✔️latest
️✔️3.12
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️maps
️✔️latest
️✔️3.12
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.9
️✔️profile
️✔️latest
️✔️3.12
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.9
️✔️redis
️✔️latest
️✔️3.12
️✔️3.9
️✔️relay
️✔️latest
️✔️3.12
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️role
️✔️latest
️✔️3.12
️✔️3.9
️✔️search
️✔️latest
️✔️3.12
️✔️3.9
️✔️security
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.9
️✔️sql
️✔️latest
️✔️3.12
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9
️✔️util
️✔️latest
️✔️3.12
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.12
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.12
️✔️3.9
️✔️latest
️✔️3.12
️✔️3.9

Copy link

Hi @calvinhzy,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

azure-client-tools-bot-prd bot commented Feb 24, 2025

⚠️AzureCLI-BreakingChangeTest
⚠️storage
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd storage account file-service-usage cmd storage account file-service-usage added
⚠️ 1006 - ParaAdd storage share-rm create cmd storage share-rm create added parameter paid_bursting_enabled
⚠️ 1006 - ParaAdd storage share-rm create cmd storage share-rm create added parameter paid_bursting_max_bandwidth_mibps
⚠️ 1006 - ParaAdd storage share-rm create cmd storage share-rm create added parameter paid_bursting_max_iops
⚠️ 1006 - ParaAdd storage share-rm create cmd storage share-rm create added parameter provisioned_bandwidth_mibps
⚠️ 1006 - ParaAdd storage share-rm create cmd storage share-rm create added parameter provisioned_iops
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter access_tier: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter access_tier: added property type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter account_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter account_name: added property type=string
⚠️ 1009 - ParaPropRemove storage share-rm create cmd storage share-rm create update parameter account_name: removed property id_part=name
⚠️ 1010 - ParaPropUpdate storage share-rm create cmd storage share-rm create update parameter account_name: updated property name from account_name to storage_account
⚠️ 1010 - ParaPropUpdate storage share-rm create cmd storage share-rm create update parameter account_name: updated property options from ['--storage-account'] to ['--account-name', '--storage-account']
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter enabled_protocols: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter enabled_protocols: added property type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter metadata: added property aaz_type=AAZDictArg
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter metadata: added property type=Dict<String,String>
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm create cmd storage share-rm create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter root_squash: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter root_squash: added property type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter share_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter share_name: added property type=string
⚠️ 1009 - ParaPropRemove storage share-rm create cmd storage share-rm create update parameter share_name: removed property id_part=child_name_2
⚠️ 1010 - ParaPropUpdate storage share-rm create cmd storage share-rm create update parameter share_name: updated property options from ['--name', '-n'] to ['--name', '--share-name', '-n']
⚠️ 1008 - ParaPropAdd storage share-rm create cmd storage share-rm create update parameter share_quota: added property aaz_type=int
⚠️ 1010 - ParaPropUpdate storage share-rm create cmd storage share-rm create update parameter share_quota: updated property name from share_quota to quota
⚠️ 1004 - CmdPropRemove storage share-rm delete cmd storage share-rm delete removed property confirmation
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter account_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter account_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm delete cmd storage share-rm delete update parameter account_name: updated property name from account_name to storage_account
⚠️ 1010 - ParaPropUpdate storage share-rm delete cmd storage share-rm delete update parameter account_name: updated property options from ['--storage-account'] to ['--account-name', '--storage-account']
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter include: added property aaz_default=none
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter include: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter include: added property type=string
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm delete cmd storage share-rm delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter share_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter share_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm delete cmd storage share-rm delete update parameter share_name: updated property options from ['--name', '-n'] to ['--name', '--share-name', '-n']
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter x_ms_snapshot: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm delete cmd storage share-rm delete update parameter x_ms_snapshot: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm delete cmd storage share-rm delete update parameter x_ms_snapshot: updated property name from x_ms_snapshot to snapshot
⚠️ 1006 - ParaAdd storage share-rm list cmd storage share-rm list added parameter filter
⚠️ 1006 - ParaAdd storage share-rm list cmd storage share-rm list added parameter maxpagesize
⚠️ 1006 - ParaAdd storage share-rm list cmd storage share-rm list added parameter pagination_limit
⚠️ 1006 - ParaAdd storage share-rm list cmd storage share-rm list added parameter pagination_token
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter account_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter account_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm list cmd storage share-rm list update parameter account_name: updated property name from account_name to storage_account
⚠️ 1010 - ParaPropUpdate storage share-rm list cmd storage share-rm list update parameter account_name: updated property options from ['--storage-account'] to ['--account-name', '--storage-account']
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_deleted: added property aaz_type=bool
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_deleted: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_deleted: added property nargs=?
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_deleted: added property type=bool
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_snapshot: added property aaz_type=bool
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_snapshot: added property choices=['0', '1', 'f', 'false', 'n', 'no', 't', 'true', 'y', 'yes']
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_snapshot: added property nargs=?
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter include_snapshot: added property type=bool
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm list cmd storage share-rm list update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm list cmd storage share-rm list update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter account_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter account_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm show cmd storage share-rm show update parameter account_name: updated property name from account_name to storage_account
⚠️ 1010 - ParaPropUpdate storage share-rm show cmd storage share-rm show update parameter account_name: updated property options from ['--storage-account'] to ['--account-name', '--storage-account']
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter expand: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter expand: added property type=string
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm show cmd storage share-rm show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter share_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter share_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm show cmd storage share-rm show update parameter share_name: updated property options from ['--name', '-n'] to ['--name', '--share-name', '-n']
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter x_ms_snapshot: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm show cmd storage share-rm show update parameter x_ms_snapshot: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm show cmd storage share-rm show update parameter x_ms_snapshot: updated property name from x_ms_snapshot to snapshot
⚠️ 1006 - ParaAdd storage share-rm update cmd storage share-rm update added parameter paid_bursting_enabled
⚠️ 1006 - ParaAdd storage share-rm update cmd storage share-rm update added parameter paid_bursting_max_bandwidth_mibps
⚠️ 1006 - ParaAdd storage share-rm update cmd storage share-rm update added parameter paid_bursting_max_iops
⚠️ 1006 - ParaAdd storage share-rm update cmd storage share-rm update added parameter provisioned_bandwidth_mibps
⚠️ 1006 - ParaAdd storage share-rm update cmd storage share-rm update added parameter provisioned_iops
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter access_tier: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter access_tier: added property type=string
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter account_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter account_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm update cmd storage share-rm update update parameter account_name: updated property name from account_name to storage_account
⚠️ 1010 - ParaPropUpdate storage share-rm update cmd storage share-rm update update parameter account_name: updated property options from ['--storage-account'] to ['--account-name', '--storage-account']
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter metadata: added property aaz_type=AAZDictArg
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter metadata: added property type=Dict<String,String>
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm update cmd storage share-rm update update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter root_squash: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter root_squash: added property type=string
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter share_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter share_name: added property type=string
⚠️ 1010 - ParaPropUpdate storage share-rm update cmd storage share-rm update update parameter share_name: updated property options from ['--name', '-n'] to ['--name', '--share-name', '-n']
⚠️ 1008 - ParaPropAdd storage share-rm update cmd storage share-rm update update parameter share_quota: added property aaz_type=int
⚠️ 1010 - ParaPropUpdate storage share-rm update cmd storage share-rm update update parameter share_quota: updated property name from share_quota to quota

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 24, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@calvinhzy calvinhzy assigned calvinhzy and unassigned evelyn-ys Feb 25, 2025
@calvinhzy calvinhzy marked this pull request as ready for review February 25, 2025 03:25
@calvinhzy calvinhzy merged commit eddda37 into Azure:dev Feb 25, 2025
53 checks passed
CustardTart32 pushed a commit to CustardTart32/azure-cli that referenced this pull request Feb 27, 2025
…Files provisioned v2 skus, add `az storage account file-service-usage` (Azure#30873)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Storage az storage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants