{App config} Breakdown tests into different files #30772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
added 2 commits
February 10, 2025 15:39
ChristineWanjau
changed the title
ChristineWanjau
changed the title
ChristineWanjau
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
albertofori
reviewed
Feb 20, 2025
| $env:AZURE_CLI_LOCAL_TEST_RESOURCE_PREFIX=$prefix | ||
|
|
||
| # Run tests | ||
| azdev test appconfig --live |
There was a problem hiding this comment.
nit: I think we should pass the --live parameter too so users can also run the tests not necessarily in live mode.
There was a problem hiding this comment.
Makes sense, updated
| Param( | ||
| [Parameter()] | ||
| [ValidateSet('clean_up')] | ||
| [string]$clean_up, |
There was a problem hiding this comment.
nit: Maybe use the switch parameter type here instead of string so you can just have a boolean check?
There was a problem hiding this comment.
Makes sense, Updated
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
please note that Azure CLI will freeze the code on 02/25/2025 10:00 UTC for the upcoming release. If you want to catch this release train, please resolve the comments ASAP, otherwise this PR has to be postponed to next sprint. |
added 2 commits
February 25, 2025 12:27
albertofori
approved these changes
Feb 25, 2025
yanzhudd
approved these changes
Feb 25, 2025
zhoxing-ms
approved these changes
Feb 26, 2025
CustardTart32
pushed a commit
to CustardTart32/azure-cli
that referenced
this pull request
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
This PR breaksdown our test file into different test files depending on the module being tested.
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.