[Backup] BREAKING CHANGE: az backup item set-policy: Add warning prompt for migration from Standard to Enhanced Policy
#28317
Conversation
zubairabid
requested review from
zhoxing-ms,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| backup item set-policy | cmd backup item set-policy added parameter yes |
|
Backup |
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
| warning_prompt = ('Upgrading to enhanced policy can incur additional charges. Once upgraded to the enhanced ' | ||
| 'policy, it is not possible to revert back to the standard policy. Do you want to continue?') | ||
| if not prompt_y_n(warning_prompt): | ||
| logger.warning('Cancelling policy update operation') | ||
| return None |
There was a problem hiding this comment.
I would like to confirm if this prompt will cause a breaking change to the customer's automation script?
There was a problem hiding this comment.
It will. This scenario is only triggered in very rare situations where a trusted launch VM was protected by a standard policy (which is not permitted anymore).
should I add a --yes/-y flag that skips this warning prompt?
There was a problem hiding this comment.
@zhoxing-ms I've pushed this change, please review it.
There was a problem hiding this comment.
Have you evaluated how many customers will be affected by this breaking change? If the impact is a little big, I suggest releasing this feature in the next breaking change window (Build Sprint)
There was a problem hiding this comment.
Have you evaluated how many customers will be affected by this breaking change? If the impact is a little big, I suggest releasing this feature in the next breaking change window (Build Sprint)
The impact would be on any customers who already have automation scripts setup to migrate from standard to enhanced backup policy. This is a specialized scenario, so it should not be a very major impact, but I'll check with our PMs for their recommendation as well.
There was a problem hiding this comment.
but I'll check with our PMs for their recommendation as well.
May I ask if this change has been confirmed? If not, since we'll have a code freeze at 02/27/2024 10:00 UTC, this PR may has to be postponed to next sprint (04-02).
There was a problem hiding this comment.
but I'll check with our PMs for their recommendation as well.
May I ask if this change has been confirmed? If not, since we'll have a code freeze at 02/27/2024 10:00 UTC, this PR may has to be postponed to next sprint (04-02).
Sorry for the delay, would it be possible to push it through in this sprint still? The PM had asked for customer usage of the command in the last 3 months. I just checked, and for the general case (not just this specific scenario), the command has been run < 500 times in the last 3 months, and only one day had > 30 calls, indicating existing automation. I think the customer impact for this change is negligible, and we should be able to proceed with this.
|
please fix the CI issues. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
modified the milestones:
February 2024 (2024-03-05),
March 2024 (2024-04-02)
zhoxing-ms
changed the title
az backup item set-policy: Add warning message for migration from Standard to Enhanced Policyaz backup item set-policy: Add warning message for migration from Standard to Enhanced Policy
zhoxing-ms
changed the title
az backup item set-policy: Add warning message for migration from Standard to Enhanced Policyaz backup item set-policy: Add warning prompt for migration from Standard to Enhanced Policy
Related command
az backup item set-policyDescription
Add warning message for migration from Standard to Enhanced Policy
Testing Guide
History Notes
az backup item set-policy: Add warning message for migration from Standard to Enhanced PolicyThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.