{Batch} Upgrade api-version to v2023-11-01 #28315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cRui861
requested review from
jsntcy,
kairu-ms,
wangzelin007,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| batch pool create | cmd batch pool create added parameter caching |
||
| batch pool create | cmd batch pool create added parameter disk_size_gb |
||
| batch pool create | cmd batch pool create added parameter encryption_at_host |
||
| batch pool create | cmd batch pool create added parameter placement |
||
| batch pool create | cmd batch pool create added parameter resource_tags |
||
| batch pool create | cmd batch pool create added parameter secure_boot_enabled |
||
| batch pool create | cmd batch pool create added parameter security_type |
||
| batch pool create | cmd batch pool create added parameter storage_account_type |
||
| batch pool create | cmd batch pool create added parameter v_tpm_enabled |
||
| batch pool create | cmd batch pool create added parameter write_accelerator_enabled |
|
Batch |
cRui861
force-pushed
the
rechen/2023-11-01
branch
2 times, most recently
from
a80c653 to
c9cf612
Compare
cRui861
force-pushed
the
rechen/2023-11-01
branch
from
c9cf612 to
c168049
Compare
zhoxing-ms
reviewed
Feb 22, 2024
zhoxing-ms
reviewed
Feb 22, 2024
zhoxing-ms
reviewed
Feb 22, 2024
zhoxing-ms
reviewed
Feb 22, 2024
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
|
Could you please resolve these CI issues? #28315 (comment) |
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 04-02) |
yanzhudd
changed the title
zhoxing-ms
approved these changes
Feb 27, 2024
necusjz
approved these changes
Feb 27, 2024
jiasli
reviewed
Mar 5, 2024
Comment on lines
+384
to
+386
| self.cmd( | ||
| 'batch account login -g {rg} -n {byos_n}' | ||
| ) |
There was a problem hiding this comment.
This command interferes with batch account login from test_batch_general_arm_cmd and causes failure when test_batch_byos_account_cmd and test_batch_general_arm_cmd are executed in parallel: #28500
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az batch
Description
--resource-tagssupport to pool addSecurityProfilesupport toVirtualMachineConfigurationon pool add--security-type,--encryption-at-host,--secure-boot-enabled, and--v-tpm-enabledOSDisksupport toVirtualMachineConfigurationon pool add--caching,--disk-size-gb,--write-accelerator-enabled, and--storage-account-typeTesting Guide
History Notes
[Batch]
az batch pool create: Add new parameter--resource-tagsto support specifying resource tags for the pool. Any resource created for the pool will then also be tagged by the same resource tags[Batch]
az batch pool create: Add new parameters--security-type,--encryption-at-host,--secure-boot-enabled, and--v-tpm-enabledto support Trusted Launch Security Type for VMs/VMSS deployments[Batch]
az batch pool create: Add new parameters--caching,--disk-size-gb,--write-accelerator-enabled, and--storage-account-typeto support Batch Node Agent temp disk-less SKUsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.