{CI} Fix regression test pipeline #28313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-ys
requested review from
kairu-ms,
jiasli,
wangzelin007,
calvinhzy and
bebound
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
CI |
bebound
reviewed
Feb 7, 2024
|
|
||
| python ../scripts/ci/automation_full_test.py "12" "$(Instance_idx)" "latest" "" "True" "extension" | ||
| displayName: "Rerun tests" | ||
| - task: AzureCLI@1 |
There was a problem hiding this comment.
Any reason to use v1 instead of v2?
There was a problem hiding this comment.
totally fine to migrate to v2. It's just initially copied from somewhere else and v1 can already satisfy our requirements.
wangzelin007
approved these changes
Feb 7, 2024
bebound
approved these changes
Feb 7, 2024
jiasli
reviewed
Feb 7, 2024
| @@ -24,7 +24,7 @@ jobs: | |||
| - task: AzureCLI@1 | |||
| displayName: 'checkout branch' | |||
| inputs: | |||
| azureSubscription: 'Azure CLI release' | |||
| azureSubscription: $(AZURE_SDK_INFRA_SUB_CONNECTED_SERVICE) | |||
There was a problem hiding this comment.
Don't expose AZURE_SDK_INFRA_SUB. Instead, consider using REGRESSION_TEST_SERVICE_CONNECTION.
jiasli
reviewed
Feb 7, 2024
| pip install $(CUSTOM_WHL_URL) --force-reinstall | ||
| fi | ||
|
|
||
| az account set -s 0b1f6471-1bf0-4dda-aec3-cb9272f09590 |
There was a problem hiding this comment.
Consider extracting subscription ID to a variable as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
After enabling MFA, regression test pipeline keeps failing with :
This PR removed the login with username password and use service connection instead
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.