{App Service} az webapp update/az appservice plan update: Add new parameter --elastic-web-app-scale-limit and scaling parameter options
#28297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amberwang113
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| appservice plan update | cmd appservice plan update update parameter max_elastic_worker_count: updated property options from ['--max-elastic-worker-count', '-m'] to ['--max-app-service-plan-instance-count', '--max-elastic-worker-count', '-m'] |
||
| webapp update | cmd webapp update added parameter elastic_web_app_scale_limit |
||
| webapp update | cmd webapp update update parameter minimum_elastic_instance_count: updated property options from ['--minimum-elastic-instance-count', '-i'] to ['--min-web-app-instance-count', '--minimum-elastic-instance-count', '-i'] |
|
App Service |
amberwang113
force-pushed
the
add-elastic-webapp-scale-limit
branch
from
a361712 to
cb9164b
Compare
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
microsoft-github-policy-service
bot
added
customer-reported
|
please resolve code conflicts. |
|
Please note that we are launching the release for this sprint this week. Please resolve all comments by tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 04-02) |
zhoxing-ms
modified the milestones:
February 2024 (2024-03-05),
March 2024 (2024-04-02)
zhoxing-ms
changed the title
az webapp update/az appservice plan update: Add elasticWebAppScaleLimit param and scaling param optionsaz webapp update/az appservice plan update: Add new parameter --elastic-web-app-scale-limit and scaling parameter options
zhoxing-ms
approved these changes
Mar 26, 2024
amberwang113
added a commit
to amberwang113/azure-cli
that referenced
this pull request
Mar 27, 2024
… Add new parameter `--elastic-web-app-scale-limit` and scaling parameter options (Azure#28297)" This reverts commit 7b64542.
zhoxing-ms
changed the title
az webapp update/az appservice plan update: Add new parameter --elastic-web-app-scale-limit and scaling parameter optionsaz webapp update/az appservice plan update: Add new parameter --elastic-web-app-scale-limit and scaling parameter options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp update
az appservice plan update
Description
Supports elastic scale for webapps by adding the
--elastic-web-app-scale-limitparameter toaz webapp update. Also adds option--min-web-app-instance-countfor the--minimum-elastic-instance-countparameter.To
az appservice plan update, this adds the option--max-app-service-plan-instance-countfor the parameter--max-elastic-worker-count. The goal of adding parameter options is to be more consistent with Portal and provide customers the option to use a uniform naming system.Testing Guide
azdev test_webapp_elastic_scale_elastic_web_app_scale_limit
azdev test_webapp_elastic_scale_min_elastic_instance_count
test_webapp_elastic_scale
History Notes
[App Service]
az webapp update: Add new parameter--elastic-web-app-scale-limitand scaling parameter options[App Service]
az appservice plan update: Add new parameter--elastic-web-app-scale-limitand scaling parameter optionsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.