[Network] az network lb create: Support cross-subscription resource ID
#28247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @ReaNAiveD, |
️✔️AzureCLI-BreakingChangeTest
|
|
Network |
microsoft-github-policy-service
bot
requested review from
kairu-ms,
AllyW and
necusjz
microsoft-github-policy-service
bot
added
the
Network
ReaNAiveD
changed the title
az network lb create: support cross-subscription resource IDaz network lb create: Support cross-subscription resource ID
ReaNAiveD
requested review from
zhoxing-ms,
wangzelin007,
yanzhudd,
jiasli,
evelyn-ys and
calvinhzy
as code owners
zhoxing-ms
reviewed
Jan 29, 2024
Comment on lines
-178
to
+179
| def resource_exists(cli_ctx, resource_group, name, namespace, type, **_): # pylint: disable=redefined-builtin | ||
| def resource_exists(cli_ctx, subscription, resource_group, name, namespace, type, | ||
| **_): # pylint: disable=redefined-builtin |
There was a problem hiding this comment.
Have you confirmed that inserting subscription parameter in the middle of the parameter list will not cause parameter misalignment issues in previous calls?
There was a problem hiding this comment.
Please note that this is a method in the azure-cli-core, so we also need to consider the invocation of other external dependencies such as CLI extensions. If you are not 100% confident, it is recommended to insert subscription parameter at the end of the parameter list.
There was a problem hiding this comment.
I have checked the usage of this function in azure-cli and azure-cli-extensions.
It is only used by two functions: get_folded_parameter_validator (in core/commands/templated_create.py) and _resource_not_exists (in vm/_actions.py).
get_folded_parameter_validator uses **resource_id_parts and there is always a subscription in the parts.
And I have updated the call in _resource_not_exists accordingly.
zhoxing-ms
approved these changes
Jan 29, 2024
necusjz
approved these changes
Jan 30, 2024
jsntcy
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az network lb createDescription
Resolve #28003
Support cross subscription resource id for
--subnetand--public-ip-addressTesting Guide
network lb create -g myRG -n myLB --subnet SubnetId --sku Standardnetwork lb create -g myRG -n myLB --public-ip-address PublicIpAddressId --sku StandardHistory Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.