{AKS} az aks create: Correct use of "comma-separated" in help
#28245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mboersma
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @mboersma, |
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
bot
requested review from
yonzhan and
FumingZhang
|
AKS |
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
reviewed
Jan 25, 2024
mboersma
force-pushed
the
comma-separated
branch
from
0ab4f80 to
07bba06
Compare
mboersma
changed the title
az aks create: correct use of "comma-separated" in helpaz aks create: Correct use of "comma-separated" in help
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
changed the title
az aks create: Correct use of "comma-separated" in helpaz aks create: Correct use of "comma-separated" in help
|
Please note that we'll have a code freeze at 02/27/2024 10:00 UTC. Please address all comments by that time, otherwise it has to be postponed to next sprint (next release train: 04-02). |
zhoxing-ms
modified the milestones:
February 2024 (2024-03-05),
March 2024 (2024-04-02)
|
I'm not seeing what the issue is in most of these logs; it doesn't appear to be related to my fix. The credential scanner fails this way:
I don't think this PR created these problems, but if it it did, please let me know where.
This PR fixes some bad English, is a month old, and AFAICT is complete. @yanzhudd if azure-cli doesn't want it, feel free to close. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
zhoxing-ms
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create --helpDescription
This fixes some typos and missing hyphens in the phrase "comma-separated".
Testing Guide
History Notes
[AKS]
az aks create: Correct use of "comma-separated" in helpThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.