[App Service] az webapp up/create/update: Add new parameter --basic-auth to allow users to enable and disable basic auth
#28237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnjefff
requested review from
jsntcy,
zhoxing-ms and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @shnjefff, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| webapp create | cmd webapp create added parameter basic_auth |
||
| webapp up | cmd webapp up added parameter basic_auth |
||
| webapp update | cmd webapp update added parameter basic_auth |
|
App Service |
microsoft-github-policy-service
bot
requested review from
yonzhan and
wangzelin007
shnjefff
changed the title
shnjefff
changed the title
shnjefff
changed the title
az webapp up/create/update --basic-auth: allow user to enable and disable basic auth
zhoxing-ms
reviewed
Jan 23, 2024
| @@ -160,6 +160,7 @@ def load_arguments(self, _): | |||
| c.argument('subnet', help="Name or resource ID of the pre-existing subnet to have the webapp join. The --vnet is argument also needed if specifying subnet by name.") | |||
| c.argument('public_network_access', help="Enable or disable public access to the web app", arg_type=get_enum_type(PUBLIC_NETWORK_ACCESS_MODES)) | |||
| c.argument('acr_use_identity', action='store_true', help="Enable or disable pull image from acr use managed identity") | |||
| c.argument('basic_auth', options_list=['--basic-auth'], help='Enable or disable basic auth.') | |||
There was a problem hiding this comment.
Suggested change
| c.argument('basic_auth', options_list=['--basic-auth'], help='Enable or disable basic auth.') | |
| c.argument('basic_auth', action='store_true', help='Enable or disable basic auth.') |
There was a problem hiding this comment.
options_list=['--basic-auth']
There is no need to explicitly declare the default option name
There was a problem hiding this comment.
action='store_true'
Please select the appropriate type for the Bool variable
zhoxing-ms
reviewed
Jan 23, 2024
zhoxing-ms
reviewed
Jan 23, 2024
shnjefff
changed the title
az webapp up/create/update --basic-auth: allow user to enable and disable basic authaz webapp up/create/update --basic-auth`: allow user to enable and disable basic auth
shnjefff
changed the title
az webapp up/create/update --basic-auth`: allow user to enable and disable basic authaz webapp up/create/update --basic-auth: allow user to enable and disable basic auth
shnjefff
changed the title
az webapp up/create/update --basic-auth: allow user to enable and disable basic authaz webapp up/create/update --basic-auth: Allow user to enable and disable basic auth
shnjefff
changed the title
az webapp up/create/update --basic-auth: Allow user to enable and disable basic authaz webapp up/create/update --basic-auth`: Allow user to enable and disable basic auth
shnjefff
changed the title
az webapp up/create/update --basic-auth`: Allow user to enable and disable basic authaz webapp up/create/update --basic-auth``: Allow user to enable and disable basic auth
zhoxing-ms
changed the title
az webapp up/create/update --basic-auth``: Allow user to enable and disable basic authaz webapp up/create/update: Add new parameter --basic-auth to allow users to enable and disable basic auth
|
Please add some scenario tests for this new feature |
zhoxing-ms
reviewed
Feb 5, 2024
| @@ -160,6 +160,7 @@ def load_arguments(self, _): | |||
| c.argument('subnet', help="Name or resource ID of the pre-existing subnet to have the webapp join. The --vnet is argument also needed if specifying subnet by name.") | |||
| c.argument('public_network_access', help="Enable or disable public access to the web app", arg_type=get_enum_type(PUBLIC_NETWORK_ACCESS_MODES)) | |||
| c.argument('acr_use_identity', action='store_true', help="Enable or disable pull image from acr use managed identity") | |||
| c.argument('basic_auth', type=str, help='Enable or disable basic auth.') | |||
There was a problem hiding this comment.
Please refer to public_network_access parameter and define it as arg_type=get_enum_type()
zhoxing-ms
approved these changes
Feb 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az webapp up -g --name --basic-auth enabled/disabled
az webapp update -g --name --basic-auth enabled/disabled
az webapp create -g -p --name --basic-auth enabled/disabled
Description
This pr add --basic-auth parameter to webapp create/up/update so that customers can toggle basic auth settings. The default value for --basic-auth is "" (empty string), which will not change existing settings. Customers only allow to input two values: "enabled" and "disabled" case insensitively. Any other values will raise exception.
Testing Guide
create a webapp and use related command to change the basic auth setting
If enabled, you should see basic auth publishing as on. Otherwise off
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.