-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[App Service] az webapp up
: Add --track-status
parameter to use deployment status API (#28235)
#28235
Merged
zhoxing-ms
merged 9 commits into
Azure:dev
from
sarsharma:webapp_up_deploymentstatusapi
Jan 25, 2024
Merged
[App Service] az webapp up
: Add --track-status
parameter to use deployment status API (#28235)
#28235
zhoxing-ms
merged 9 commits into
Azure:dev
from
sarsharma:webapp_up_deploymentstatusapi
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
️✔️AzureCLI-FullTest
|
Hi @sarsharma, |
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
webapp deployment source config-zip | cmd webapp deployment source config-zip added parameter track_status |
||
webapp up | cmd webapp up added parameter track_status |
App Service |
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
Please fix CI issues first. |
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
rupareddy5-21
approved these changes
Jan 24, 2024
vivekjilla
approved these changes
Jan 24, 2024
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
Signed-off-by: Sarthak Sharma <sartsharma@microsoft.com>
kumaramit-msft
approved these changes
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
--track-status
arg to use deploymentstatus API
--track-status
arg to use deploymentstatus APIaz webapp up
: Add --track-status
arg to use deploymentstatus API
zhoxing-ms
approved these changes
Jan 25, 2024
az webapp up
: Add --track-status
arg to use deploymentstatus APIaz webapp up
: Add --track-status
parameter to use deployment status API (#28235)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ARM
az resource/group/lock/tag/deployment/policy/managementapp/account management-group
Auto-Assign
Auto assign by bot
Web Apps
az webapp
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in continuation of changes done for #27548
Related command
az webapp up --track-status
az webapp deployment source config-zip --track-status
Description
Support to allow use of deploymentstatus API to track the status for
az webapp deploy
was added via #27548 This PR is for adding this suport usingaz webapp up
andaz deployment source config-zip
as well. The deploymentstatus API provides additional granular updates about the status of the app deployment. Keeping this additional verbose info behind an argument flag--track-status
.Screenshots
Testing Guide
Deploying webapps using CLI with command
az webapp up
oraz webapp deployment source-config
along with arg--track-status
History Notes
[App Service]
az webapp up
: Add--track-status
arg to use deploymentstatus API[App Service]
az webapp deployment source config-zip
: Add--track-status
arg to use deploymentstatus APIThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.