[ContainerRegistry] <DO NOT MERGE> Add 'acrcssc' extension for public preview #8530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Fix LINT and Style issues # Add more unit test # Add defer_run_immediately support in the CLI command # Change the command from supply-chain task to supply-chain workflow - Need to read document # Change the show command to display cadence as "n"d instead of cron expression, order the list by name # Check if Resource_group is coming as mandatory field Or it can be set in the config and can be fetched directly from there
remove redundant files
Fix formatting Fix bugs
breaking test cases
…azure-cli-extensions into users/puwalech/acrcssc
…azure-cli-extensions into users/puwalech/acrcssc
help file default values in documentation test invalid json values
…azure-cli-extensions into users/puwalech/acrcssc
…n under a Poller
…re it is assigned
…t_check feat(cssc): 31229526 add image limit check during create and update
…grunning fix(cssc): 31670277 Remove LongRunningOperation wrapper for task updates
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @cegraybl, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
|
Hi @cegraybl
|
…-convention schema validation to strictly allow for only incremental or floating
fix(cssc): 31694722 fixed config validation to only allow tag-convention = floating or incremental
fix(cssc): 31694219 inform user when images matching their configuration are 0
…s (2/n) (#25) - Add ScenarioTest for the extension and the recording - Fix remaining style and lint issues - Fix README file to reflect basic usage - Fix HISTORY and setup.py to have the final release version for private preview
github-actions
bot
added
the
release-version-block
…ests (#31) Currently, no validation error is thrown when repositories are empty or repeated in configuration file. Bug - https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31695069/?view=edit This PR fixes the issue by enhancing schema validation for repositories and updating the tests to test for this scenario.  --------- Co-authored-by: Ruchi Maheshwari <rumahe@microsoft.com>
…e calling list command + enhance log message (#32) This PR adds a check to ensure that the cssc tasks exist before calling the list command. It also displays that the list command is executed for the last n days. Updated tests as well. With this, below 2 bugs are addressed: 1. https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694510/?view=edit Before Fix:  After Fix:  2. https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694600/?view=edit After Fix: added a line to indicate list executed for last n days:  --------- Co-authored-by: Ruchi Maheshwari <rumahe@microsoft.com>
AllyW
reviewed
Mar 12, 2025
| logger.warn("Wheel is not available, disabling bdist_wheel hook") | ||
|
|
||
| VERSION = '1.1.1' | ||
|
|
There was a problem hiding this comment.
Please adjust the initial version for acrcssc to be 1.0.0b1, instead of 1.1.1
For more info about the extension versioning schema, please refer to doc here:https://github.com/Azure/azure-cli/blob/dev/doc/extensions/versioning_guidelines.md#initialization
…iately options are mutually exclusive (#33) Added validation to ensure that the `--dryrun` and `--run-immediately` options cannot be used together both during create and update. Also added unit tests for this scenario to ensure the validation works as expected. Bug - https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/31694592/?view=edit After fix:  Co-authored-by: Ruchi Maheshwari <rumahe@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
CSSC (Container Secure Supply Chain) is an extension that configures your registry for continuous scanning and patching of container images. With the Continuous Patching feature in Azure Container Registry, you can automatically scan and patch designated artifacts for OS-level vulnerabilities. The workflow allows you to schedule recurring ACR tasks that scan your list of configured images for vulnerabilities (CVEs) using Trivy and then patch them using Copa.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.Pending items before the publishing PR
HISTORY.rstandREADME.rstwith required documentation