Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add create-from-machines #8529

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented Mar 5, 2025


  • Add command az scvmm create-from-machines.
  • PR changes are similar to connectedvmware PR.

Related command

az scvmm

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 5, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️scvmm
rule cmd_name rule_message suggest_message
⚠️ 1001 - CmdAdd scvmm vm create-from-machines cmd scvmm vm create-from-machines added

Copy link

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Mar 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

github-actions bot commented Mar 5, 2025

Hi @nascarsayan

Release Suggestions

Module: connectedvmware

  • Please log updates into to src/connectedvmware/HISTORY.rst
  • Update VERSION to 1.2.2 in src/connectedvmware/setup.py

Notes

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 5, 2025
@yonzhan yonzhan requested review from zhoxing-ms and yanzhudd March 5, 2025 23:22
Copy link

github-actions bot commented Mar 6, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@nascarsayan nascarsayan force-pushed the scvmm-create-from-machines branch from b274880 to 34603e2 Compare March 6, 2025 06:46
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Mar 6, 2025
@nascarsayan nascarsayan requested a review from AllyW March 7, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants