{portal}az portal dashboard: Revert name max length change
#8521
Conversation
|
Hi @cxznmhdcxz, |
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @cxznmhdcxz, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
| @@ -49,7 +49,6 @@ def _build_arguments_schema(cls, *args, **kwargs): | |||
| help="The name of the dashboard.", | |||
| required=True, | |||
| fmt=AAZStrArgFormat( | |||
| pattern="^[a-zA-Z0-9-]{3,24}$", | |||
There was a problem hiding this comment.
why not change it to {3,64}
There was a problem hiding this comment.
There is no pattern before bumping api version, and actually a dashboard could have a name longer then 64 characters, I think let the server check the name length?
resolve #8491
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.