Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Confluent] Add cmdlets for API version 2024-07-01 stable #8520

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

almasak
Copy link
Member

@almasak almasak commented Mar 3, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 3, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️confluent
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd confluent agreement sub group confluent agreement added
⚠️ 1011 - SubgroupAdd confluent organization access sub group confluent organization access added
⚠️ 1010 - ParaPropUpdate confluent organization api-key delete cmd confluent organization api-key delete update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1001 - CmdAdd confluent organization api-key show cmd confluent organization api-key show added
⚠️ 1001 - CmdAdd confluent organization create-role-bindings cmd confluent organization create-role-bindings added
⚠️ 1011 - SubgroupAdd confluent organization environment cluster connector sub group confluent organization environment cluster connector added
⚠️ 1001 - CmdAdd confluent organization environment cluster create cmd confluent organization environment cluster create added
⚠️ 1010 - ParaPropUpdate confluent organization environment cluster create-api-key cmd confluent organization environment cluster create-api-key update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1001 - CmdAdd confluent organization environment cluster delete cmd confluent organization environment cluster delete added
⚠️ 1010 - ParaPropUpdate confluent organization environment cluster list cmd confluent organization environment cluster list update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1010 - ParaPropUpdate confluent organization environment cluster show cmd confluent organization environment cluster show update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1011 - SubgroupAdd confluent organization environment cluster topic sub group confluent organization environment cluster topic added
⚠️ 1001 - CmdAdd confluent organization environment cluster update cmd confluent organization environment cluster update added
⚠️ 1001 - CmdAdd confluent organization environment create cmd confluent organization environment create added
⚠️ 1001 - CmdAdd confluent organization environment delete cmd confluent organization environment delete added
⚠️ 1010 - ParaPropUpdate confluent organization environment list cmd confluent organization environment list update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1010 - ParaPropUpdate confluent organization environment schema-registry-cluster list cmd confluent organization environment schema-registry-cluster list update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1010 - ParaPropUpdate confluent organization environment schema-registry-cluster show cmd confluent organization environment schema-registry-cluster show update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1001 - CmdAdd confluent organization environment show cmd confluent organization environment show added
⚠️ 1001 - CmdAdd confluent organization environment update cmd confluent organization environment update added
⚠️ 1010 - ParaPropUpdate confluent organization list-role-binding cmd confluent organization list-role-binding update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1010 - ParaPropUpdate confluent organization list-service-accounts cmd confluent organization list-service-accounts update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1010 - ParaPropUpdate confluent organization list-users cmd confluent organization list-users update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']
⚠️ 1010 - ParaPropUpdate confluent organization role-binding delete cmd confluent organization role-binding delete update parameter resource_group: updated property options from ['--resource-group'] to ['--resource-group', '-g']

Copy link

Hi @almasak,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @almasak,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 3, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Mar 3, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

github-actions bot commented Mar 3, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Mar 3, 2025

@kairu-ms
Copy link
Contributor

Hi @almasak, please add tests for them and add examples for the put or post method generated commands. It's required for GA release.

@kairu-ms kairu-ms requested a review from AllyW March 13, 2025 00:21
@AllyW
Copy link
Member

AllyW commented Mar 13, 2025

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants