Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{serviceconnector-passwordless} <DO NOT MERGE> add interactive prompt to confirm user has read documentation #8516

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tonychen0227
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 28, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Tonychen0227,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @Tonychen0227,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 28, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Feb 28, 2025

@Tonychen0227 Tonychen0227 changed the title {serviceconnector-passwordless} add interactive prompt to confirm user has read documentation {serviceconnector-passwordless} <DO NOT MERGE> add interactive prompt to confirm user has read documentation Mar 4, 2025
@yonzhan
Copy link
Collaborator

yonzhan commented Mar 4, 2025

This PR title contains "DO NOT MERGE".

@Tonychen0227
Copy link
Contributor Author

This PR title contains "DO NOT MERGE".

Yes, this PR is not ready for merge - the code changes itself are ready, but the dependency features are not yet ready.

I'll update this PR to remove the DO NOT MERGE tag once the dependency feature is ready, and bump the version accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants