Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Network Fabric to 8.0.0b1 CLI Version with new API 2024-06-15-preview #8512

Draft
wants to merge 36 commits into
base: main
Choose a base branch
from

Conversation

nafizhaider32
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Feb 26, 2025

❌Azure CLI Extensions Breaking Change Test
❌managednetworkfabric
rule cmd_name rule_message suggest_message
1007 - ParaRemove networkfabric externalnetwork create cmd networkfabric externalnetwork create removed parameter export_route_policy_id please add back parameter export_route_policy_id for cmd networkfabric externalnetwork create
1007 - ParaRemove networkfabric externalnetwork create cmd networkfabric externalnetwork create removed parameter import_route_policy_id please add back parameter import_route_policy_id for cmd networkfabric externalnetwork create
1007 - ParaRemove networkfabric externalnetwork update cmd networkfabric externalnetwork update removed parameter export_route_policy_id please add back parameter export_route_policy_id for cmd networkfabric externalnetwork update
1007 - ParaRemove networkfabric externalnetwork update cmd networkfabric externalnetwork update removed parameter import_route_policy_id please add back parameter import_route_policy_id for cmd networkfabric externalnetwork update
1002 - CmdRemove networkfabric interface delete cmd networkfabric interface delete removed please confirm cmd networkfabric interface delete removed
1007 - ParaRemove networkfabric internalnetwork create cmd networkfabric internalnetwork create removed parameter export_route_policy_id please add back parameter export_route_policy_id for cmd networkfabric internalnetwork create
1007 - ParaRemove networkfabric internalnetwork create cmd networkfabric internalnetwork create removed parameter import_route_policy_id please add back parameter import_route_policy_id for cmd networkfabric internalnetwork create
1007 - ParaRemove networkfabric internalnetwork update cmd networkfabric internalnetwork update removed parameter export_route_policy_id please add back parameter export_route_policy_id for cmd networkfabric internalnetwork update
1007 - ParaRemove networkfabric internalnetwork update cmd networkfabric internalnetwork update removed parameter import_route_policy_id please add back parameter import_route_policy_id for cmd networkfabric internalnetwork update
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter acl_type
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter device_role
⚠️ 1006 - ParaAdd networkfabric acl create cmd networkfabric acl create added parameter global_access_control_list_actions
⚠️ 1008 - ParaPropAdd networkfabric acl create cmd networkfabric acl create update parameter default_action: added property aaz_default=Permit
⚠️ 1008 - ParaPropAdd networkfabric acl create cmd networkfabric acl create update parameter default_action: added property default=Permit
⚠️ 1006 - ParaAdd networkfabric acl update cmd networkfabric acl update added parameter acl_type
⚠️ 1006 - ParaAdd networkfabric acl update cmd networkfabric acl update added parameter device_role
⚠️ 1006 - ParaAdd networkfabric acl update cmd networkfabric acl update added parameter global_access_control_list_actions
⚠️ 1010 - ParaPropUpdate networkfabric controller create cmd networkfabric controller create update parameter infra_er_connections: updated property name from infra_er_connections to infrastructure_express_route_connections
⚠️ 1010 - ParaPropUpdate networkfabric controller create cmd networkfabric controller create update parameter infra_er_connections: updated property options from ['--infra-er-connections'] to ['--infra-er-connections', '--infrastructure-express-route-connections']
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter ipv4_address_space: added property aaz_default=10.0.0.0/19
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter ipv4_address_space: added property default=10.0.0.0/19
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter ipv6_address_space: added property aaz_default=FC00::/59
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter ipv6_address_space: added property default=FC00::/59
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter is_workload_management_network_enabled: added property aaz_default=True
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter is_workload_management_network_enabled: added property default=True
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter nfc_sku: added property aaz_default=Standard
⚠️ 1008 - ParaPropAdd networkfabric controller create cmd networkfabric controller create update parameter nfc_sku: added property default=Standard
⚠️ 1010 - ParaPropUpdate networkfabric controller create cmd networkfabric controller create update parameter workload_er_connections: updated property name from workload_er_connections to workload_express_route_connections
⚠️ 1010 - ParaPropUpdate networkfabric controller create cmd networkfabric controller create update parameter workload_er_connections: updated property options from ['--workload-er-connections'] to ['--workload-er-connections', '--workload-express-route-connections']
⚠️ 1010 - ParaPropUpdate networkfabric controller update cmd networkfabric controller update update parameter infra_er_connections: updated property name from infra_er_connections to infrastructure_express_route_connections
⚠️ 1010 - ParaPropUpdate networkfabric controller update cmd networkfabric controller update update parameter infra_er_connections: updated property options from ['--infra-er-connections'] to ['--infra-er-connections', '--infrastructure-express-route-connections']
⚠️ 1010 - ParaPropUpdate networkfabric controller update cmd networkfabric controller update update parameter workload_er_connections: updated property name from workload_er_connections to workload_express_route_connections
⚠️ 1010 - ParaPropUpdate networkfabric controller update cmd networkfabric controller update update parameter workload_er_connections: updated property options from ['--workload-er-connections'] to ['--workload-er-connections', '--workload-express-route-connections']
⚠️ 1001 - CmdAdd networkfabric device reboot cmd networkfabric device reboot added
⚠️ 1010 - ParaPropUpdate networkfabric device update-admin-state cmd networkfabric device update-admin-state update parameter state: updated property choices from ['Enable', 'GracefulQuarantine', 'Quarantine', 'RMA', 'Resync', 'UnderMaintenance'] to ['Disable', 'Enable', 'GracefulQuarantine', 'Quarantine', 'RMA', 'Resync', 'UnderMaintenance', 'UngracefulQuarantine', 'UngracefulRMA']
⚠️ 1006 - ParaAdd networkfabric externalnetwork create cmd networkfabric externalnetwork create added parameter static_route_configuration
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork create cmd networkfabric externalnetwork create update parameter nni_id: updated property name from nni_id to network_to_network_interconnect_id
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork create cmd networkfabric externalnetwork create update parameter nni_id: updated property options from ['--nni-id'] to ['--network-to-network-interconnect-id', '--nni-id']
⚠️ 1006 - ParaAdd networkfabric externalnetwork update cmd networkfabric externalnetwork update added parameter static_route_configuration
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork update cmd networkfabric externalnetwork update update parameter nni_id: updated property name from nni_id to network_to_network_interconnect_id
⚠️ 1010 - ParaPropUpdate networkfabric externalnetwork update cmd networkfabric externalnetwork update update parameter nni_id: updated property options from ['--nni-id'] to ['--network-to-network-interconnect-id', '--nni-id']
⚠️ 1001 - CmdAdd networkfabric externalnetwork update-bfd-administrative-state cmd networkfabric externalnetwork update-bfd-administrative-state added
⚠️ 1001 - CmdAdd networkfabric fabric arm-configuration-diff cmd networkfabric fabric arm-configuration-diff added
⚠️ 1001 - CmdAdd networkfabric fabric commit-batch-status cmd networkfabric fabric commit-batch-status added
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter control_plane_acls
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter hardware_alert_threshold
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter storage_account_configuration
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter storage_array_count
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter trusted_ip_prefixes
⚠️ 1006 - ParaAdd networkfabric fabric create cmd networkfabric fabric create added parameter unique_rd_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter managed_network_config: updated property name from managed_network_config to management_network_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter managed_network_config: updated property options from ['--managed-network-config'] to ['--managed-network-config', '--management-network-configuration']
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter nf_sku: updated property name from nf_sku to network_fabric_sku
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter nf_sku: updated property options from ['--nf-sku'] to ['--network-fabric-sku', '--nf-sku']
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter nfc_id: updated property name from nfc_id to network_fabric_controller_id
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter nfc_id: updated property options from ['--nfc-id'] to ['--network-fabric-controller-id', '--nfc-id']
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter ts_config: updated property name from ts_config to terminal_server_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric create cmd networkfabric fabric create update parameter ts_config: updated property options from ['--ts-config'] to ['--terminal-server-configuration', '--ts-config']
⚠️ 1001 - CmdAdd networkfabric fabric discard-commit-batch cmd networkfabric fabric discard-commit-batch added
⚠️ 1011 - SubgroupAdd networkfabric fabric identity sub group networkfabric fabric identity added
⚠️ 1001 - CmdAdd networkfabric fabric lock-fabric cmd networkfabric fabric lock-fabric added
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter control_plane_acls
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter hardware_alert_threshold
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter mi_system_assigned
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter mi_user_assigned
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter storage_account_configuration
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter trusted_ip_prefixes
⚠️ 1006 - ParaAdd networkfabric fabric update cmd networkfabric fabric update added parameter unique_rd_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric update cmd networkfabric fabric update update parameter managed_network_config: updated property name from managed_network_config to management_network_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric update cmd networkfabric fabric update update parameter managed_network_config: updated property options from ['--managed-network-config'] to ['--managed-network-config', '--management-network-configuration']
⚠️ 1010 - ParaPropUpdate networkfabric fabric update cmd networkfabric fabric update update parameter ts_config: updated property name from ts_config to terminal_server_configuration
⚠️ 1010 - ParaPropUpdate networkfabric fabric update cmd networkfabric fabric update update parameter ts_config: updated property options from ['--ts-config'] to ['--terminal-server-configuration', '--ts-config']
⚠️ 1001 - CmdAdd networkfabric fabric view-device-configuration cmd networkfabric fabric view-device-configuration added
⚠️ 1001 - CmdAdd networkfabric interface update cmd networkfabric interface update added
⚠️ 1010 - ParaPropUpdate networkfabric interface update-admin-state cmd networkfabric interface update-admin-state update parameter state: updated property choices from ['Disable', 'Enable'] to ['Disable', 'Enable', 'UnderMaintenance']
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter native_ipv4_prefix_limit
⚠️ 1006 - ParaAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create added parameter native_ipv6_prefix_limit
⚠️ 1008 - ParaPropAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter extension: added property aaz_default=NoExtension
⚠️ 1008 - ParaPropAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter extension: added property default=NoExtension
⚠️ 1008 - ParaPropAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter is_monitoring_enabled: added property aaz_default=False
⚠️ 1008 - ParaPropAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter is_monitoring_enabled: added property default=False
⚠️ 1008 - ParaPropAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter mtu: added property aaz_default=1500
⚠️ 1008 - ParaPropAdd networkfabric internalnetwork create cmd networkfabric internalnetwork create update parameter mtu: added property default=1500
⚠️ 1006 - ParaAdd networkfabric internalnetwork update cmd networkfabric internalnetwork update added parameter native_ipv4_prefix_limit
⚠️ 1006 - ParaAdd networkfabric internalnetwork update cmd networkfabric internalnetwork update added parameter native_ipv6_prefix_limit
⚠️ 1006 - ParaAdd networkfabric l2domain create cmd networkfabric l2domain create added parameter extended_vlan
⚠️ 1006 - ParaAdd networkfabric l2domain create cmd networkfabric l2domain create added parameter network_to_network_interconnect_id
⚠️ 1008 - ParaPropAdd networkfabric l2domain create cmd networkfabric l2domain create update parameter mtu: added property aaz_default=1500
⚠️ 1008 - ParaPropAdd networkfabric l2domain create cmd networkfabric l2domain create update parameter mtu: added property default=1500
⚠️ 1010 - ParaPropUpdate networkfabric l2domain create cmd networkfabric l2domain create update parameter nf_id: updated property name from nf_id to network_fabric_id
⚠️ 1010 - ParaPropUpdate networkfabric l2domain create cmd networkfabric l2domain create update parameter nf_id: updated property options from ['--nf-id'] to ['--network-fabric-id', '--nf-id']
⚠️ 1006 - ParaAdd networkfabric l2domain update cmd networkfabric l2domain update added parameter extended_vlan
⚠️ 1006 - ParaAdd networkfabric l2domain update cmd networkfabric l2domain update added parameter network_to_network_interconnect_id
⚠️ 1010 - ParaPropUpdate networkfabric l2domain update-admin-state cmd networkfabric l2domain update-admin-state update parameter state: updated property choices from ['Disable', 'Enable'] to ['Disable', 'Enable', 'UnderMaintenance']
⚠️ 1006 - ParaAdd networkfabric l3domain create cmd networkfabric l3domain create added parameter route_prefix_limit
⚠️ 1006 - ParaAdd networkfabric l3domain create cmd networkfabric l3domain create added parameter static_route_route_policy
⚠️ 1010 - ParaPropUpdate networkfabric l3domain create cmd networkfabric l3domain create update parameter nf_id: updated property name from nf_id to network_fabric_id
⚠️ 1010 - ParaPropUpdate networkfabric l3domain create cmd networkfabric l3domain create update parameter nf_id: updated property options from ['--nf-id'] to ['--network-fabric-id', '--nf-id']
⚠️ 1008 - ParaPropAdd networkfabric l3domain create cmd networkfabric l3domain create update parameter redistribute_connected_subnets: added property aaz_default=True
⚠️ 1008 - ParaPropAdd networkfabric l3domain create cmd networkfabric l3domain create update parameter redistribute_connected_subnets: added property default=True
⚠️ 1008 - ParaPropAdd networkfabric l3domain create cmd networkfabric l3domain create update parameter redistribute_static_routes: added property aaz_default=False
⚠️ 1008 - ParaPropAdd networkfabric l3domain create cmd networkfabric l3domain create update parameter redistribute_static_routes: added property default=False
⚠️ 1006 - ParaAdd networkfabric l3domain update cmd networkfabric l3domain update added parameter route_prefix_limit
⚠️ 1006 - ParaAdd networkfabric l3domain update cmd networkfabric l3domain update added parameter static_route_route_policy
⚠️ 1010 - ParaPropUpdate networkfabric l3domain update-admin-state cmd networkfabric l3domain update-admin-state update parameter state: updated property choices from ['Disable', 'Enable'] to ['Disable', 'Enable', 'UnderMaintenance']
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter conditional_default_route_configuration
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter micro_bfd_state
⚠️ 1006 - ParaAdd networkfabric nni create cmd networkfabric nni create added parameter static_route_configuration
⚠️ 1008 - ParaPropAdd networkfabric nni create cmd networkfabric nni create update parameter is_management_type: added property aaz_default=True
⚠️ 1008 - ParaPropAdd networkfabric nni create cmd networkfabric nni create update parameter is_management_type: added property default=True
⚠️ 1008 - ParaPropAdd networkfabric nni create cmd networkfabric nni create update parameter nni_type: added property aaz_default=CE
⚠️ 1008 - ParaPropAdd networkfabric nni create cmd networkfabric nni create update parameter nni_type: added property default=CE
⚠️ 1006 - ParaAdd networkfabric nni update cmd networkfabric nni update added parameter micro_bfd_state
⚠️ 1006 - ParaAdd networkfabric nni update cmd networkfabric nni update added parameter static_route_configuration
⚠️ 1001 - CmdAdd networkfabric nni update-bfd-administrative-state cmd networkfabric nni update-bfd-administrative-state added
⚠️ 1008 - ParaPropAdd networkfabric routepolicy create cmd networkfabric routepolicy create update parameter address_family_type: added property aaz_default=IPv4
⚠️ 1008 - ParaPropAdd networkfabric routepolicy create cmd networkfabric routepolicy create update parameter address_family_type: added property default=IPv4
⚠️ 1008 - ParaPropAdd networkfabric routepolicy create cmd networkfabric routepolicy create update parameter default_action: added property aaz_default=Deny
⚠️ 1008 - ParaPropAdd networkfabric routepolicy create cmd networkfabric routepolicy create update parameter default_action: added property default=Deny
⚠️ 1010 - ParaPropUpdate networkfabric routepolicy create cmd networkfabric routepolicy create update parameter nf_id: updated property name from nf_id to network_fabric_id
⚠️ 1010 - ParaPropUpdate networkfabric routepolicy create cmd networkfabric routepolicy create update parameter nf_id: updated property options from ['--nf-id'] to ['--network-fabric-id', '--nf-id']
⚠️ 1008 - ParaPropAdd networkfabric tap create cmd networkfabric tap create update parameter polling_type: added property aaz_default=Pull
⚠️ 1008 - ParaPropAdd networkfabric tap create cmd networkfabric tap create update parameter polling_type: added property default=Pull
⚠️ 1010 - ParaPropUpdate networkfabric tap update-admin-state cmd networkfabric tap update-admin-state update parameter state: updated property choices from ['Disable', 'Enable'] to ['Disable', 'Enable', 'UnderMaintenance']
⚠️ 1006 - ParaAdd networkfabric taprule create cmd networkfabric taprule create added parameter global_network_tap_rule_actions
⚠️ 1008 - ParaPropAdd networkfabric taprule create cmd networkfabric taprule create update parameter polling_interval_in_seconds: added property aaz_default=30.0
⚠️ 1008 - ParaPropAdd networkfabric taprule create cmd networkfabric taprule create update parameter polling_interval_in_seconds: added property default=30.0
⚠️ 1010 - ParaPropUpdate networkfabric taprule create cmd networkfabric taprule create update parameter polling_interval_in_seconds: updated property aaz_type from int to float
⚠️ 1010 - ParaPropUpdate networkfabric taprule create cmd networkfabric taprule create update parameter polling_interval_in_seconds: updated property type from int to float
⚠️ 1006 - ParaAdd networkfabric taprule update cmd networkfabric taprule update added parameter global_network_tap_rule_actions

Copy link

Hi @nafizhaider32,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

Copy link

Hi @nafizhaider32,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Feb 26, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@nafizhaider32 nafizhaider32 changed the title Updating Network Fabric to 8.0 CLI Version Updating Network Fabric to 8.0.0b1 CLI Version with new API 2024-06-15-preview Feb 26, 2025
Copy link

github-actions bot commented Feb 26, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 26, 2025
@nafizhaider32 nafizhaider32 marked this pull request as draft February 26, 2025 22:34
@AllyW AllyW added the preview release extension module as preview label Feb 27, 2025
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot do-not-merge Network preview release extension module as preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants