Other forms #77
Merged
Other forms #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…quest concert form screen navigate (todo: fix cannot read property map of undefined when request concert button pressed)
… now they are in the volunteer forms spreadsheet, not yet a button in other opportunities
…input boxes. Bugs: validation (only for this form, probably this specific question), margin 20 instead of 0
|
🚀 Expo preview is ready!
|
TenType
previously requested changes
Sep 4, 2024
…ontent (performanceType dynamic changing still works)
- Fix circular dependency errors - Fix LMH/MBT time limit validation - Align with OOP by refactoring common methods into the base Form class
- Remove unused imports - Organize imports - Add required indicator to the RequestConcert time slot Rename - Rename Slot -> TimeSlotList to prevent ambiguity
TenType
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dance Club & Request Concert Functionality added!
(I tried to find a more gender-neutral icon for the dance club thing but the only other ones were a ball dance and pole dancing)
(there is also one small ui issue, that is the gap between each of the music pieces' text boxes, aka bottom margin, is 20, though in the code it is set to 0 (on all but the last one ofc to add a margin between it and the next question). 10 instead of 0 also doesn't work.)