Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge volunteer form screens #41

Merged
merged 17 commits into from
Jul 12, 2024

Conversation

Pramad712
Copy link
Contributor

@Pramad712 Pramad712 commented Jul 10, 2024

New Version:
image
image
image
(Composer thing messed up do to screen size issue, should be better on a real device)
image
image
image
image

  1. Everything is scrollable after the back button and header
  2. Time Limit is dynamic
  3. The spacing on the top is only visible in Android, not in iOS (Can someone pls help me fix)
  4. For now, all the info is printed when the next button is pressed. It is also part of the scrolling so that everything must be seen for it to be shown.
  5. If you exit out of the window, the data won't be saved, but if you switch windows to a different app, it will be saved (cannot be tested when a new window is open in the app itself due to screen navigation not being applied yet. This saving is done with useState)
  6. Validation is included: first & last name must be included (& middle ones if applicable), performance type must be selected the length must be no more than the time limit (and > 0), the recording link must be valid, and the rest must not be empty or be 0. The border of the input box's border becomes red if it is invalid. For the multiple-choice-performance-type, it's title becomes red if unselected.

TODO: Scroll Up to the first invalid question

Closes #37
Closes #38

Copy link

github-actions bot commented Jul 10, 2024

🚀 Expo preview is ready!

  • Project → audacity-music-club
  • Platforms → android, ios
  • Runtime Version → 1.0.0
  • More info

Learn more about 𝝠 Expo Github Action

@Pramad712 Pramad712 requested a review from TenType July 12, 2024 05:09
@TenType TenType changed the title Merge Contact Info, Music Piece, and Performance Details Screens into Volunteer Form, Make Boxes Inputtable, Add Scrolling, Fix UI Bugs Merge volunteer form screens Jul 12, 2024
@TenType TenType merged commit 7f0d92d into main Jul 12, 2024
2 checks passed
@TenType TenType deleted the Inputable-Boxes-and-Contact-Info-Music-Piece-Merging branch July 12, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save input data across form submission screens Music Piece screen
2 participants