Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RAM minter #1319

Merged
merged 180 commits into from
Apr 1, 2024
Merged

RAM minter #1319

merged 180 commits into from
Apr 1, 2024

Conversation

ryley-o
Copy link
Contributor

@ryley-o ryley-o commented Jan 11, 2024 •
edited
Loading

Description of the change

Add a new RAM minter.

Please see internal design document for minter implementation details.

Gas Performance

The following are a summary of the gas tests added in /test/minter-suite-minters/RAM/MinterRAM/gas.test.ts, which are intended to represent typical operations performed on the minter.

note: all gas performance scales infinitely with project size

Operation Avg Gas Used Comment
Initial bids 85k first bid uses ~175k gas due to initialization of pointers
bids after max bids reached 107k first bid uses ~150k due to initialization of pointers
gas per admin/artist minted token ~53k assumes bulk-minting chunks of tokens at a time

TODO:

  • Add tests for full coverage of new libraries and contracts

ryley-o added 30 commits January 10, 2024 16:56
@ryley-o
initial structuring
d511eba
@ryley-o
reasonable bucket sort insert/remove implementation
85b7a70
@ryley-o
add min heap lib, reach parity with RAMLib for min heap
895919d
@ryley-o
add minter refund limit updated events to libs
ebcac35
@ryley-o
add createBid functionality, view min bid to RAM minter
0e21cb4
@ryley-o
move lib function for styleguide
0071d04
@ryley-o
implement minimal auction config in RAM minter for testing
6b87738
@ryley-o
implement minimal MinterRAMMinHeapV0 for testing
1291b91
@ryley-o
bug fixes and gas tests for study
4bc7007
@ryley-o
don't track bid slot index in Bid since implicitly defined elsewhere
be1d339
@ryley-o
states-flags-errors
bfe88cd
@ryley-o
nits to state definitions
9060091
@ryley-o
remove/archive min-heap study files
0c60d0b
@ryley-o
Merge pull request #1336 from ArtBlocks/ram-minter-leaf
aa92586 
RAM minter temp leaf
@ryley-o
update RAMLib to use dual BitMap256 for 512 bid slots
5bf85eb
@ryley-o
Merge branch 'main' into ram-minter
2a91055
@ryley-o
update pricing mechanics
1c6f6f6
@ryley-o
add logic for auction extension time
102ff04
@ryley-o
add percent bid value checks
3781032
@ryley-o
admin-configurable admin-only mint period if sellout
cc41627
@ryley-o
Merge branch 'main' into ram-minter
db8810a
@ryley-o
Implement State A abilities, setContractConfig
4056bf0
@ryley-o
fully add createBid functionality
94ade00
@ryley-o
add ability for admin to increase auction end time up to 72 hours (fr…
875c748 
…ontend downtime)
@ryley-o
update createBid to be external
01b8569
@ryley-o
Add ability for collectors to collect settlements
8ce236c
@ryley-o
add event for bid settled, bug fix price calc
d582e81
@ryley-o
functions for admin to mint tokens to winners
273e05b
@ryley-o
Merge branch 'main' into ram-minter
77da63b
@ryley-o
add refund capabilites to resolve E1
122b898
@lindsgil
Rename invocationsRemain to invocationsRemainOnCore and revert change…
1abcc70 
…s to the projectMaxHasBeenInvokedSafe function
@lindsgil
Updat
4c4fdcf 
e projectMaxHasBeenInvokedSafe to call getInvocationsAvailable
ryley-o
ryley-o commented Mar 26, 2024
View reviewed changes
Copy link
Contributor Author

@ryley-o ryley-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Consider this my approval (I can't approve since I opened this PR)
just minor coverage nits is all 🍾 really excited about this!

@ryley-o ryley-o removed the do not merge Not auto-merge-able label Mar 26, 2024
lindsgil and others added 11 commits March 27, 2024 09:57
@lindsgil @ryley-o
Update packages/contracts/contracts/libs/v0.8.x/BitMap.sol
1f9ac1d 
Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
@lindsgil @ryley-o
Update packages/contracts/contracts/libs/v0.8.x/minter-libs/RAMLib.sol
81e83ec 
Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
@lindsgil @ryley-o
Update packages/contracts/contracts/libs/v0.8.x/minter-libs/RAMLib.sol
927e02d 
Co-authored-by: ryley-o <30364988+ryley-o@users.noreply.github.com>
@lindsgil
Update comments + placement of bid existence check
3947423
@lindsgil
Merge branch 'ram-minter' of github.com:ArtBlocks/artblocks-contracts…
6653a56 
… into ram-minter
@lindsgil
Fix tests
2fd96bf
@lindsgil
Merge branch 'main' into ram-minter
2f64e95
@lindsgil
Added reentrancy test on purchase function and added a dev comment
94e8a51
@lindsgil
Merge branch 'ram-minter' of github.com:ArtBlocks/artblocks-contracts…
b6d4add 
… into ram-minter
@lindsgil
Add test that validates that removing the last active bid for a slot …
c23f355 
…that is NOT the minBidSlotIndex does not update the minBidSlotIndex
@lindsgil
Update reentrancy test to pass the correct value in call
afd85d2
@ryley-o ryley-o enabled auto-merge April 1, 2024 20:20
@ryley-o ryley-o merged commit 0b6473b into main Apr 1, 2024
10 of 11 checks passed
@ryley-o ryley-o deleted the ram-minter branch April 1, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsgil lindsgil lindsgil approved these changes

@lyaunzbe lyaunzbe lyaunzbe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryley-o @lyaunzbe @lindsgil