Use SpawnLogic instead of custom RespawnSystemComponent #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature added after EPF overrode the respawn system component. I think this is simpler and more in line with using the vanilla systems where applicable and only making custom when necessary.
|
I'll have a look at this, but am not sure what the advantages are. I had to override some logic in the system component or else it would create troubles, namely |
|
I think the main advantage is just following vanilla organization and having the spawn logic in a separate class makes it very clear to follow the logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, in my project I moved the respawn logic to use the (relatively new versus when this was originally made) SpawnLogic class. The base respawn system component removed the logic from itself and separated it into another class to keep it organized. I prefer this, and maybe you will too, so I've made a pull request that just moves the spawning logic to use this new setup. The only difference is you keep the SCR_RespawnSystemComponent and set the spawn logic to EPF_BasicSpawnLogic or EPF_BaseSpawnLogic. I have also done this for the everon life spawning logic and will submit a pull request there as well.