Fix: Hero Slider Issue #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👏 Thanks for opening this pull request! Please check out our contributing guidelines. Your contribution makes a difference! 💪 |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
🥳 Congrats on merging your first pull request! 🎉 We here at Behaviorbot are proud of you! Keep up the great work! 🙌 💥 |
|
@ragul1697 thanks a lot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71 - Issue with
Hero SliderHey there, I am not an expert in React.js But I made a simple fix for the hero slider issue.
In your app, preloader is running for
2 secondsand after that theHomecomponent loaded and at the endscript.jsfile gets called. But in realtime, this is not working properly. TheheroSliderItemsis empty when the DOM load event is ended and theautoSlidefunction cannot update the sliders.The
DOMContentLoadedis called even the preloader is running because we importedscript.jsin theApp.jsfile.