Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InboxItems + InboxItem #195

Merged
merged 10 commits into from
Feb 9, 2024
Merged

InboxItems + InboxItem #195

merged 10 commits into from
Feb 9, 2024

Conversation

seanes
Copy link
Contributor

@seanes seanes commented Feb 8, 2024

Adds InboxItems + InboxItem which a 1st iteration stab at the component outlined in Figma.
I've added a story to Storybook to demonstrate the usage and added it to a separate route (/inbox) to demo it in the application.

This PR also includes a couple of rabbit hole tasks in order to make the first story work properly, like including Inter fonts.

image

import { SealIcon, StarIcon } from "@navikt/aksel-icons";

import { InboxItems } from "../../../../frontend-design-poc/src/components/InboxItems";
import { InboxItem } from "../../../../frontend-design-poc/src/components/InboxItem";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unsure about importing stuff thats outside the package.

Instead one might add frontend-design-poc as a dependency of this package and use it that way.

https://pnpm.io/workspaces

I think the dependency becomes something like workspace:frontend-design-poc or something similare.


Either that or we move the InboxItems into the storybook package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree ... not very in favor of doing this either. I will have a look into workspaces. Thanks

@TheKnarf
Copy link
Contributor

TheKnarf commented Feb 9, 2024

Group InboxItem and InboxItems into the same folder, so that you can use them as a single import:

import { InboxItems, InboxItem } from '../components/InboxItem';

Components that are used together should live together.

Copy link
Contributor

@alexdigdir alexdigdir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra jobba :D

}

.icon {
margin-right: 0.375em;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Er en del blanding av em/rem, er det noen grunn til å ikke holde oss til kun rem? Det gjelder forsåvidt bruken av "px" også, men dette går litt over i design og møtet vi skal ha til mandag :)

@alexdigdir alexdigdir merged commit d6db695 into main Feb 9, 2024
4 checks passed
@alexdigdir alexdigdir deleted the feature/inboxItems branch February 9, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants