-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InboxItems + InboxItem #195
Conversation
import { SealIcon, StarIcon } from "@navikt/aksel-icons"; | ||
|
||
import { InboxItems } from "../../../../frontend-design-poc/src/components/InboxItems"; | ||
import { InboxItem } from "../../../../frontend-design-poc/src/components/InboxItem"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unsure about importing stuff thats outside the package.
Instead one might add frontend-design-poc
as a dependency of this package and use it that way.
I think the dependency becomes something like workspace:frontend-design-poc
or something similare.
Either that or we move the InboxItems
into the storybook
package.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree ... not very in favor of doing this either. I will have a look into workspaces. Thanks
Group
Components that are used together should live together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bra jobba :D
} | ||
|
||
.icon { | ||
margin-right: 0.375em; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Er en del blanding av em/rem, er det noen grunn til å ikke holde oss til kun rem? Det gjelder forsåvidt bruken av "px" også, men dette går litt over i design og møtet vi skal ha til mandag :)
Adds InboxItems + InboxItem which a 1st iteration stab at the component outlined in Figma.
I've added a story to Storybook to demonstrate the usage and added it to a separate route (
/inbox
) to demo it in the application.This PR also includes a couple of rabbit hole tasks in order to make the first story work properly, like including
Inter
fonts.