Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/restructure app #188

Merged
merged 2 commits into from
Feb 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/frontend-design-poc/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
"@digdir/design-system-tokens": "^0.12.0",
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-query": "^3.39.3"
"react-query": "^3.39.3",
"react-router-dom": "^6.16.0"
},
"devDependencies": {
"@testing-library/react": "^14.1.2",
Expand Down
25 changes: 15 additions & 10 deletions packages/frontend-design-poc/src/App.tsx
Original file line number Diff line number Diff line change
@@ -1,15 +1,20 @@
import { QueryClient, QueryClientProvider } from 'react-query';
import { HelloWorld } from './components/HelloWorld/HelloWorld.tsx';
import styles from './app.module.css'

const queryClient = new QueryClient();
import { Route, Routes } from "react-router-dom";
import { HelloWorld } from "./components/HelloWorld";
import { PageNotFound } from "./pages/PageNotFound";
import { PageLayout } from "./pages/PageLayout";
import styles from "./app.module.css";

function App() {
return (<QueryClientProvider client={queryClient}>
<section data-testid="app" className={styles.app}>
<HelloWorld />
</section>
</QueryClientProvider>);
return (
<div className={styles.app} role="main">
<Routes>
<Route element={<PageLayout />}>
<Route path="/" element={<HelloWorld />} />
<Route path="*" element={<PageNotFound />} />
</Route>
</Routes>
</div>
);
}

export default App;
19 changes: 12 additions & 7 deletions packages/frontend-design-poc/src/app.spec.tsx
Original file line number Diff line number Diff line change
@@ -1,11 +1,16 @@
import { describe, it, expect } from 'vitest';
import { render } from '@testing-library/react';
import App from './App.tsx';
import { beforeAll, describe, expect, it } from "vitest";
import { customRender } from "../utils/test-utils.tsx";
import App from "./App.tsx";
import { server } from "./mocks/node.ts";

describe('App Smoke Test', () => {
it('renders without crashing', () => {
const { getByTestId } = render(<App />);
const appElement = getByTestId('app');
describe("App Smoke Test", async () => {
beforeAll(async () => {
server.listen();
});

it("renders without crashing", () => {
const { getByRole } = customRender(<App />);
const appElement = getByRole("main");
expect(appElement).toBeTruthy();
});
});
Original file line number Diff line number Diff line change
@@ -1,11 +1,12 @@
import styles from './helloWorld.module.css';
import { useQuery } from 'react-query';
import { getUser } from '../../api/queries.ts';
import styles from "./helloWorld.module.css";
import { useQuery } from "react-query";
import { getUser } from "../../api/queries.ts";

export const HelloWorld = () => {
const { isLoading, data } = useQuery('user', getUser);

return (<section className={styles.helloWorld}>
const { isLoading, data } = useQuery("user", getUser);
return (
<section className={styles.helloWorld}>
{isLoading ? <span>Loading ...</span> : <h1>Hello, {data?.name}!</h1>}
</section>);
};
</section>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { HelloWorld } from "./HelloWorld.tsx";
28 changes: 19 additions & 9 deletions packages/frontend-design-poc/src/main.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,27 @@
import React from 'react';
import ReactDOM from 'react-dom/client';
import App from './App.tsx';
import React from "react";
import ReactDOM from "react-dom/client";
import App from "./App.tsx";
import { QueryClient, QueryClientProvider } from "react-query";
import { BrowserRouter } from "react-router-dom";

async function enableMocking() {
if (import.meta.env.MODE === 'development') {
const { worker } = await import('./mocks/browser');
if (import.meta.env.MODE === "development") {
const { worker } = await import("./mocks/browser");
return worker.start();
}
}

const root = ReactDOM.createRoot(document.getElementById("root")!);
const queryClient = new QueryClient();

enableMocking().then(() => {
ReactDOM.createRoot(document.getElementById('root')!).render(<React.StrictMode>
<App />
</React.StrictMode>);
root.render(
<React.StrictMode>
<QueryClientProvider client={queryClient}>
<BrowserRouter>
<App />
</BrowserRouter>
</QueryClientProvider>
</React.StrictMode>,
);
});

4 changes: 4 additions & 0 deletions packages/frontend-design-poc/src/mocks/node.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
import { setupServer } from 'msw/node'
import { handlers } from './handlers'

export const server = setupServer(...handlers)
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
import { Outlet } from "react-router-dom";

export const PageLayout = () => {
return (
<>
<nav aria-label="hovedmeny" />
<Outlet />
</>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { PageLayout } from './PageLayout';
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
export const PageNotFound = () => {
return (
<div>
<h1>Ooops... page not found :(</h1>
</div>
);
};
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
export { PageNotFound } from "./PageNotFound.tsx";
33 changes: 33 additions & 0 deletions packages/frontend-design-poc/utils/test-utils.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
import { QueryClient, QueryClientProvider } from "react-query";
import { ReactElement } from "react";
import { MemoryRouter } from "react-router-dom";
import { render, RenderOptions } from "@testing-library/react";

interface IExtendedRenderOptions extends RenderOptions {
initialEntries?: string[];
}

const queryClient = new QueryClient({
defaultOptions: {
queries: {
retry: false,
},
},
});

export const customRender = (
ui: ReactElement,
options?: Omit<IExtendedRenderOptions, "wrapper">,
) => {
const Wrapper = ({ children }: { children: React.ReactNode }) => {
return (
<QueryClientProvider client={queryClient}>
<MemoryRouter initialEntries={options?.initialEntries ?? ["/"]}>
{children}
</MemoryRouter>
</QueryClientProvider>
);
};

return render(ui, { wrapper: Wrapper, ...options });
};
3 changes: 3 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading