Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

👷 Initial PNPM, Biome & Turbo setup #152

Merged
merged 2 commits into from
Feb 2, 2024
Merged

👷 Initial PNPM, Biome & Turbo setup #152

merged 2 commits into from
Feb 2, 2024

Conversation

TheKnarf
Copy link
Contributor

@TheKnarf TheKnarf commented Jan 30, 2024 •
edited
Loading

  • PNPM
  • Biome
  • Turborepo setup

TODO in the future:

  • Fix Dockerfiles

@TheKnarf TheKnarf requested review from seanes and alexdigdir January 30, 2024 12:14
@TheKnarf TheKnarf force-pushed the feature/biome-turbo branch from 0a6a095 to 7d371da Compare January 30, 2024 13:11
@TheKnarf TheKnarf marked this pull request as draft January 31, 2024 08:54
@TheKnarf TheKnarf force-pushed the feature/biome-turbo branch 10 times, most recently from 8b3dad9 to 694af78 Compare February 1, 2024 13:47
@TheKnarf TheKnarf marked this pull request as ready for review February 1, 2024 13:47
@TheKnarf TheKnarf force-pushed the feature/biome-turbo branch 13 times, most recently from 9edfc2e to 5ee280a Compare February 1, 2024 14:45
@TheKnarf TheKnarf changed the title 👷 Initial Biome & Turbo setup 👷 Initial PNPM, Biome & Turbo setup Feb 1, 2024
seanes
seanes reviewed Feb 2, 2024
View reviewed changes
@seanes
Copy link
Contributor

seanes commented Feb 2, 2024

Nice! Care to explain why you landed on node v 18 in Dockerfile?

@TheKnarf
Copy link
Contributor Author

TheKnarf commented Feb 2, 2024

Nice! Care to explain why you landed on node v 18 in Dockerfile?

Thats just a mistake from my part, started updating the Dockerfile and then we agreed that it should be its own PR. So brought back the old Dockerfile from the main-branch before the Node upgrade PR was merged 🤦‍♂️

I'll update this pr...

@TheKnarf TheKnarf force-pushed the feature/biome-turbo branch 5 times, most recently from 5a6478e to b32e2a8 Compare February 2, 2024 10:21
@TheKnarf
👷 Initial Biome & Turbo setup
0ebd4f5 
In the future this the config files needs to be adopted to the project.
As well as Github Actions. This is just a first step for setup.

Fixes #160
Fixes #158
@TheKnarf TheKnarf force-pushed the feature/biome-turbo branch from b32e2a8 to 7bb65b2 Compare February 2, 2024 13:23
@TheKnarf TheKnarf force-pushed the feature/biome-turbo branch from 7bb65b2 to 0ef28aa Compare February 2, 2024 13:26
@TheKnarf TheKnarf merged commit 5a655d8 into main Feb 2, 2024
4 checks passed
@TheKnarf TheKnarf deleted the feature/biome-turbo branch February 2, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanes seanes seanes left review comments

@alexdigdir alexdigdir alexdigdir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheKnarf @seanes @alexdigdir