Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rabbit): exclude release pr #1128

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Sep 24, 2024

Hva er endret?

Dokumentasjon / Storybook / testdekning

  • Dokumentasjon er oppdatert eller ikke relevant / nødvendig.
  • Ny komponent har en eller flere stories i Storybook, eller så er ikke dette relevant.
  • Det er blitt lagt til nye tester / eksiterende tester er blitt utvidet, eller tester er ikke relevant.

Skjermbilder eller GIFs (valgfritt)

Summary by CodeRabbit

  • Chores
    • Updated configuration for the auto-review feature to improve commit message processing.

@arealmaas arealmaas requested a review from a team as a code owner September 24, 2024 07:29
Copy link

coderabbitai bot commented Sep 24, 2024

Walkthrough

Walkthrough

The pull request introduces a modification to the .coderabbit.yaml configuration file, specifically updating the ignore_title_keywords setting within the auto_review section. The previous keyword format "chore(main): release" has been changed to "chore: release main". This change alters the keywords that the auto-review feature will disregard during the commit message processing in the review workflow.

Changes

File Change Summary
.coderabbit.yaml Updated ignore_title_keywords from ["chore(main): release"] to ["chore: release main"].

Recent review details

Configuration used: .coderabbit.yaml
Review profile: ASSERTIVE

Commits

Files that changed from the base of the PR and between 32a6ebf and dc4a7e0.

Files selected for processing (1)
  • .coderabbit.yaml (1 hunks)
Additional comments not posted (1)
.coderabbit.yaml (1)

22-22: Approve change with suggestions for verification and documentation.

The update to the ignore_title_keywords looks intentional and aligns with the PR objective to "exclude release pr". However, I have a few suggestions:

  1. Please verify that the new format "chore: release main" is consistent with your project's commit message or PR title conventions for releases.

  2. Consider documenting the reason for this change, either in a comment within this file or in the project's documentation. This will help future contributors understand the rationale behind this specific keyword format.

To help assess the impact of this change, I can run a script to check recent PRs and see how they would be affected. Would you like me to do this?

This script will help us understand if any recent PRs would be affected differently by the new setting.

Verification successful

Change Verified

The update to ignore_title_keywords has been successfully verified. Only PR #352 (chore: release main) is now ignored, ensuring the change aligns with the project's commit message and PR title conventions.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Check recent PRs to see how they would be affected by the new ignore_title_keywords setting

# Fetch the last 50 PRs (adjust number as needed)
gh pr list --limit 50 --json number,title | jq -r '.[] | "\(.number)|\(.title)"' | while IFS='|' read -r number title; do
    if [[ $title == "chore: release main"* ]]; then
        echo "PR #$number would now be ignored: $title"
    elif [[ $title == "chore(main): release"* ]]; then
        echo "PR #$number would no longer be ignored: $title"
    fi
done

Length of output: 1666


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    -- I pushed a fix in commit <commit_id>, please review it.
    -- Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    -- @coderabbitai generate unit testing code for this file.
    -- @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    -- @coderabbitai read src/utils.ts and generate unit testing code.
    -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@arealmaas arealmaas merged commit 62da0e3 into main Sep 24, 2024
14 checks passed
@arealmaas arealmaas deleted the chore/exclude-release-pr-in-rabbit branch September 24, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants