Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: escape if wikidata properties doesn't exist #1125

Merged
merged 1 commit into from
Aug 19, 2024
Merged

hotfix: escape if wikidata properties doesn't exist #1125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions server/wikidata/wikidata.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,23 @@ export class WikidataService {
language
);

const siteLinkName = this.getSiteLinkName(language);

if (wikidata?.sitelinks[siteLinkName]) {
const wikiLang = siteLinkName.match(/^(.*)wiki$/)[1];
const wikiTitle = wikidata.sitelinks[siteLinkName].title;
if (wikiLang && wikiTitle) {
wikidataProps.wikipedia = `https://${wikiLang.replace(
"_",
"-"
)}.wikipedia.org/wiki/${encodeURI(wikiTitle)}`;
}
}

if (!wikidata.claims) {
return wikidataProps;
}

/**
* Q5 = Human
* Q891723 = Public Companies
Expand All @@ -89,9 +106,9 @@ export class WikidataService {
* https://www.wikidata.org/wiki/Q21503252
*/
const hasP31Claims =
wikidata.claims.P31 && wikidata.claims.P31.length > 0;
wikidata.claims?.P31 && wikidata.claims?.P31?.length > 0;
if (hasP31Claims) {
const isAllowedProp = wikidata.claims.P31.some((claim) => {
const isAllowedProp = wikidata.claims?.P31?.some((claim) => {
const instance = claim.mainsnak.datavalue.value;
return allowedInstances.includes(instance.id);
});
Expand All @@ -102,25 +119,14 @@ export class WikidataService {
}

// Extract image if it exists
const wikidataPropImage = wikidata.claims.P18 || wikidata.claims.P154;
const wikidataPropImage = wikidata.claims?.P18 || wikidata.claims?.P154;
if (wikidataPropImage) {
const fileName = wikidataPropImage[0].mainsnak.datavalue.value;
wikidataProps.image = await this.getCommonsThumbURL(fileName, 400);
wikidataProps.avatar = await this.getCommonsThumbURL(fileName, 100);
}
const siteLinkName = this.getSiteLinkName(language);
if (wikidata.sitelinks[siteLinkName]) {
const wikiLang = siteLinkName.match(/^(.*)wiki$/)[1];
const wikiTitle = wikidata.sitelinks[siteLinkName].title;
if (wikiLang && wikiTitle) {
wikidataProps.wikipedia = `https://${wikiLang.replace(
"_",
"-"
)}.wikipedia.org/wiki/${encodeURI(wikiTitle)}`;
}
}
// Extract Twitter accounts if they exist
if (wikidata.claims.P2002) {
if (wikidata.claims?.P2002) {
wikidata.claims.P2002.forEach((claim) => {
const twitterAccount = claim.mainsnak.datavalue.value;
wikidataProps.twitterAccounts.push(twitterAccount);
Expand Down
Loading