Merge pull request #1795 from AletheiaFact/Fixing-duplicate-fonts-bug

Fixing duplicate sources bug when creating claim
AletheiaFact · Jan 26, 2025 · 61a0b99 · 61a0b99
2 parents 306ec7d + 8212746
commit 61a0b99
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/server/claim/claim-revision/claim-revision.service.ts b/server/claim/claim-revision/claim-revision.service.ts
@@ -204,17 +204,15 @@ export class ClaimRevisionService {
         if (sources && Array.isArray(sources)) {
             for (let source of sources) {
                 try {
-                    if (typeof source === "string") {
+                    const existingSources = await this.sourceService.getSourceByHref(source);
+                    if (existingSources) {
+                            this.sourceService.updateTargetId(existingSources._id, claimId)
+                    } else {
                         await this.sourceService.create({
                             href: source,
                             targetId: claimId,
                             targetModel: SourceTargetModel.Claim,
                         });
-                    } else {
-                        await this.sourceService.updateTargetId(
-                            source._id,
-                            claimId
-                        );
                     }
                 } catch (e) {
                     this.logger.error(e);

diff --git a/server/source/source.service.ts b/server/source/source.service.ts
@@ -63,6 +63,10 @@ export class SourceService {
         return this.SourceModel.find({ match }, { _id: 1, href: 1 });
     }
 
+    getSourceByHref(href: string) {
+        return this.SourceModel.findOne({ href: { $eq: href } }).exec();
+    }
+
     getById(_id) {
         return this.SourceModel.findById(_id);
     }