[7.4-stable] Fix image cropper #3193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we check image orientation, cropperjs makes a ajax request without propper CORS headers which prevents the browser from loading the image. According [1] to the docs we need to turn off this check in order to prevent CORS issues. [1](https://github.com/fengyuanchen/cropperjs/blob/v1/README.md#checkorientation) (cherry picked from commit 9677d43)
CropperJS does not support setting the min width and a crop area on init. Since a min width is a debatable feature anyway, we just remove it and let the user decide how small the image might get. (cherry picked from commit 70a07b3)
GitHub changed how the `failure()` and `success()` function work without any warning. Thanks for that, folks! Using job outputs instead. (cherry picked from commit cd2def9)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.4-stable #3193 +/- ##
===========================================
Coverage 96.46% 96.46%
===========================================
Files 238 238
Lines 6454 6454
===========================================
Hits 6226 6226
Misses 228 228 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Mar 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.4-stable:Questions ?
Please refer to the Backport tool documentation