This repository has been archived by the owner on Apr 9, 2022. It is now read-only.
Adding a few more tests #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zkoppert
reviewed
Mar 3, 2020
| @@ -0,0 +1 @@ | |||
| @chocrates:registry=https://npm.pkg.github.com/ | |||
There was a problem hiding this comment.
@Chocrates Looks like there is an issue authenticating with the package registry.
There was a problem hiding this comment.
I suspect that a GITHUB_TOKEN is needed to install the npm package from the registry given this article but I haven’t seen anything on how to do that.
There was a problem hiding this comment.
Thanks Zack. I know I had to generate a token to publish but Im surprised id need one to pull too. Ill see what I can figure out
There was a problem hiding this comment.
There was a problem hiding this comment.
Ill give this a try this afternoon: https://github.community/t5/GitHub-Actions/Installing-npm-packages-from-the-GitHub-package-registry/m-p/46332/highlight/true#M6528
added 22 commits
March 3, 2020 12:26
…till didn't work.
… well as authenticate
zkoppert
approved these changes
Mar 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally got off my butt and finished some tests.
Closes #1